feat(profiling)!: take mime types in profile exporter#1478
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Jan 27, 2026
Merged
feat(profiling)!: take mime types in profile exporter#1478gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
danielsn
commented
Jan 27, 2026
Comment on lines
+50
to
+56
| pub enum MimeType { | ||
| ApplicationJson, | ||
| ApplicationOctetStream, | ||
| TextCsv, | ||
| TextPlain, | ||
| TextXml, | ||
| } |
Contributor
Author
There was a problem hiding this comment.
LMK if there are any other types we need to support at this time
Contributor
There was a problem hiding this comment.
Python currently uses json for code provenance and internal metadata. And pprof.
Contributor
There was a problem hiding this comment.
Node.js doesn't use libdatadog for profile uploads, but just wanted to confirm here it only uses two MIME types: application/json for event.json and application/octet-stream for the pprof files.
danielsn
force-pushed
the
dsn/profile-exporter-mine
branch
from
f82ff54 to
a36c98e
Compare
BenchmarksComparisonBenchmark execution time: 2026-01-27 16:44:56 Comparing candidate commit 746e9a3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
📚 Documentation Check Results📦
|
danielsn
force-pushed
the
dsn/profile-exporter-mine
branch
from
a36c98e to
039abf8
Compare
🔒 Cargo Deny Results📦
|
danielsn
force-pushed
the
dsn/profile-exporter-mine
branch
from
039abf8 to
0224c4b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 71.14% 71.12% -0.02%
==========================================
Files 419 419
Lines 67179 67204 +25
==========================================
+ Hits 47793 47798 +5
- Misses 19386 19406 +20
🚀 New features to boost your workflow:
|
danielsn
force-pushed
the
dsn/profile-exporter-mine
branch
from
0224c4b to
746e9a3
Compare
danielsn
force-pushed
the
dsn/profile-exporter-mine
branch
from
746e9a3 to
43e110b
Compare
taegyunkim
approved these changes
Jan 27, 2026
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
dsn/profile-exporter-mine
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Contributor
morrisonlevi
left a comment
morrisonlevi
left a comment
There was a problem hiding this comment.
This has already been committed, but I wanted to review it as well. For migration's sake, should we have put an "unknown" or "unspecified" mime type as value 0? Otherwise code may compile and send ApplicationJson, whether that's the real mime or not.
gh-worker-dd-mergequeue-cf854d bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
# What does this PR do? Reverts #1478 # Motivation As per the event-platform-intake team: // Note: We don't set Content-Type for file attachments in the multipart form. // The intake backend treats all attachments as raw bytes (application/octet-stream) // and detects compression by reading magic bytes (gzip/zstd/etc headers). // Content-Type is only meaningful for the main "event" part (set to application/json). // Attachments are not forwarded beyond intake, so their MIME types are not needed. # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated. Co-authored-by: daniel.schwartznarbonne <daniel.schwartznarbonne@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
mimefield to files we exportMotivation
Integration tests were failing because they expected a mime type. Having one is good practice.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Tests have been updated.