ci: use default-pipeline check for gitlab status rather than custom scripts#1506
Conversation
BenchmarksComparisonBenchmark execution time: 2026-02-05 18:02:24 Comparing candidate commit 177d403 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
+ Coverage 71.20% 71.22% +0.02%
==========================================
Files 424 424
Lines 69802 69802
==========================================
+ Hits 49700 49714 +14
+ Misses 20102 20088 -14
🚀 New features to boost your workflow:
|
db7df50 to
447aa62
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
dab2f7b to
ad73429
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 177d403 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ad73429 to
7ebfe2a
Compare
… as a separate branch protection rule
7ebfe2a to
177d403
Compare
|
can't we just make the gitlab post required in settings? |
|
@danielsn More or less, yes. I haven't updated the PR description yet. I un-did most of my changes. There is a new, more reliable check |
|
/gitlab resync-code |
|
View all feedbacks in Devflow UI.
resync successful |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
Attempt to fix a potential race condition with the all-checks workflow and report_gitlab_CI_status
report_gitlab_CI_statusispoststage and doesn't get created until after dependent jobs run.If all gitlab benchmark and github actions successfully complete, but
report_gitlab_CI_statushasn't been created yet, then all-checks can pass because all-checks doesn't see anything pending.The
dd-gitlab/default-pipelinecheck has been enabled for this repo by ci-infra. This should solve our problems and remove the need for custom scripts. It will pass when the Gitlab pipeline completes. This check will be added to the branch protection rule for main. all-checks will just be used for github steps.Motivation
all-checks passed on #1428 , despite tests failing on the alpine builds in gitlab.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.