Skip to content

test(crashtracking): add minimal LD preload test for crashtracker collector#1428

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 19 commits intomainfrom
gyuheon0h/prof-13289-ld-preload_
Jan 29, 2026
Merged

test(crashtracking): add minimal LD preload test for crashtracker collector#1428
gh-worker-dd-mergequeue-cf854d[bot] merged 19 commits intomainfrom
gyuheon0h/prof-13289-ld-preload_

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0h gyuheon0h commented Jan 4, 2026 •
edited
Loading

What does this PR do?

  1. Adds test_collector_no_allocations_stacktrace_modes, which runs the crash tracker under LD_PRELOAD with a custom allocator hook that logs any allocation in the collector.
  2. Executes the crashtracker binary across all StacktraceCollection modes via the env var DD_TEST_STACKTRACE_COLLECTION:
    • disabled
    • without_symbols
    • receiver_symbols
    • inprocess_symbols
  3. For each mode, the test:
    • Cleans any previous /tmp/preload_detector.log
    • Runs the crashtracker null-deref scenario with TestMode::RuntimePreloadLogger
    • After the run, checks for /tmp/preload_detector.log
    • If the mode is inprocess_symbols, it expects the log to exist (symbol resolution is known to allocate); logs are printed if present.
    • For the other modes, it expects no log.

Motivation

We want to validate all uses of non-signal-safe functions in the handler.

How to test the change?

You can run the test_collector_no_allocations_stacktrace_modes test. You can also add allocations in the signal hander path and observe the test behavior

@gyuheon0h Graphite App
Copy link
Contributor Author

gyuheon0h commented Jan 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gyuheon0h gyuheon0h changed the title First pass, need to isolate only collector from test harness [crashtracking] Add minimal LD preload test for crashtracker collector Jan 4, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 34.42623% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.03%. Comparing base (cd903df) to head (ce1d7db).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1428      +/-   ##
==========================================
+ Coverage   70.96%   71.03%   +0.07%     
==========================================
  Files         421      422       +1     
  Lines       68438    68697     +259     
==========================================
+ Hits        48567    48802     +235     
- Misses      19871    19895      +24
Components Coverage Δ
libdd-crashtracker 61.26% <0.00%> (-0.15%) ⬇️
libdd-crashtracker-ffi 16.50% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.84% <ø> (+0.56%) ⬆️
libdd-data-pipeline-ffi 78.57% <ø> (ø)
libdd-common 80.97% <ø> (ø)
libdd-common-ffi 74.54% <ø> (ø)
libdd-telemetry 59.82% <ø> (+0.03%) ⬆️
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.70% <ø> (+0.10%) ⬆️
libdd-profiling 81.51% <ø> (+0.01%) ⬆️
libdd-profiling-ffi 64.71% <ø> (ø)
datadog-sidecar 34.94% <ø> (ø)
datdog-sidecar-ffi 10.25% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 93.43% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 89.45% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 4, 2026 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2026-01-29 16:41:12

Comparing candidate commit ce1d7db in PR branch gyuheon0h/prof-13289-ld-preload_ with baseline commit 7f30d50 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.961ms 3.968ms ± 0.006ms 3.967ms ± 0.002ms 3.969ms 3.971ms 3.973ms 4.051ms 2.10% 10.973 139.709 0.16% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.967ms; 3.969ms] or [-0.022%; +0.022%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 535.276µs 536.871µs ± 1.286µs 536.462µs ± 0.553µs 537.392µs 539.085µs 541.515µs 544.128µs 1.43% 2.011 5.937 0.24% 0.091µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1837804.459op/s 1862656.203op/s ± 4439.911op/s 1864066.564op/s ± 1924.131op/s 1865675.584op/s 1867207.282op/s 1867539.779op/s 1868195.715op/s 0.22% -1.983 5.751 0.24% 313.949op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.001µs 380.685µs ± 0.541µs 380.616µs ± 0.214µs 380.851µs 381.223µs 381.929µs 385.134µs 1.19% 5.318 39.852 0.14% 0.038µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2596495.657op/s 2626849.827op/s ± 3708.101op/s 2627319.924op/s ± 1475.172op/s 2628645.556op/s 2630305.642op/s 2631150.672op/s 2631574.130op/s 0.16% -5.261 39.233 0.14% 262.202op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.259µs 189.593µs ± 0.183µs 189.553µs ± 0.112µs 189.688µs 189.976µs 190.208µs 190.243µs 0.36% 1.135 1.509 0.10% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5256424.564op/s 5274464.641op/s ± 5095.425op/s 5275572.934op/s ± 3126.088op/s 5278090.761op/s 5280696.256op/s 5281920.914op/s 5283776.746op/s 0.16% -1.129 1.490 0.10% 360.301op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.493µs 36.609µs ± 0.044µs 36.612µs ± 0.034µs 36.642µs 36.676µs 36.700µs 36.731µs 0.32% -0.118 -0.414 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 27225186.199op/s 27315448.530op/s ± 32821.615op/s 27313277.156op/s ± 25019.933op/s 27340679.354op/s 27370979.784op/s 27388287.722op/s 27402223.288op/s 0.33% 0.124 -0.413 0.12% 2320.839op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.923µs 46.053µs ± 0.104µs 46.038µs ± 0.034µs 46.080µs 46.138µs 46.223µs 47.308µs 2.76% 8.972 105.508 0.22% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21138054.040op/s 21714176.048op/s ± 47944.264op/s 21721199.951op/s ± 15844.787op/s 21733672.082op/s 21751786.929op/s 21761871.963op/s 21775554.521op/s 0.25% -8.791 102.558 0.22% 3390.171op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [536.693µs; 537.049µs] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1862040.874op/s; 1863271.532op/s] or [-0.033%; +0.033%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.610µs; 380.760µs] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2626335.920op/s; 2627363.734op/s] or [-0.020%; +0.020%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.567µs; 189.618µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5273758.464op/s; 5275170.818op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.603µs; 36.615µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27310899.770op/s; 27319997.290op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [46.039µs; 46.067µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21707531.434op/s; 21720820.662op/s] or [-0.031%; +0.031%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 551.576µs 552.269µs ± 0.414µs 552.234µs ± 0.200µs 552.436µs 552.701µs 553.045µs 556.619µs 0.79% 5.910 59.368 0.07% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [552.212µs; 552.327µs] or [-0.010%; +0.010%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.965µs 5.054µs ± 0.055µs 5.048µs ± 0.036µs 5.067µs 5.160µs 5.163µs 5.164µs 2.30% 0.720 -0.629 1.09% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.046µs; 5.061µs] or [-0.152%; +0.152%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.351µs 146.202µs ± 1.694µs 145.930µs ± 0.498µs 146.443µs 148.592µs 153.027µs 160.322µs 9.86% 4.888 32.861 1.16% 0.120µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [145.967µs; 146.436µs] or [-0.161%; +0.161%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.024µs 33.575µs ± 0.861µs 33.160µs ± 0.055µs 33.346µs 35.385µs 35.489µs 36.725µs 10.75% 1.723 1.247 2.56% 0.061µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.455µs; 33.694µs] or [-0.356%; +0.356%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.304µs 2.372µs ± 0.020µs 2.369µs ± 0.010µs 2.383µs 2.403µs 2.415µs 2.421µs 2.17% -0.491 1.105 0.86% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.369µs; 2.375µs] or [-0.120%; +0.120%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.231µs 3.186µs ± 1.425µs 3.016µs ± 0.023µs 3.039µs 3.334µs 13.838µs 15.075µs 399.80% 7.511 56.995 44.63% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.988µs; 3.383µs] or [-6.201%; +6.201%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 205.719µs 206.351µs ± 0.281µs 206.331µs ± 0.190µs 206.496µs 206.826µs 207.116µs 207.220µs 0.43% 0.590 0.240 0.14% 0.020µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4825783.352op/s 4846110.028op/s ± 6591.607op/s 4846593.209op/s ± 4468.666op/s 4851200.249op/s 4855277.533op/s 4857371.550op/s 4861001.629op/s 0.30% -0.582 0.226 0.14% 466.097op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.578µs 18.651µs ± 0.038µs 18.645µs ± 0.021µs 18.669µs 18.708µs 18.762µs 18.857µs 1.14% 1.793 7.041 0.20% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53030895.440op/s 53617017.646op/s ± 108895.151op/s 53633023.764op/s ± 59991.317op/s 53683354.873op/s 53751788.828op/s 53795857.964op/s 53825732.349op/s 0.36% -1.758 6.830 0.20% 7700.050op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.830µs 10.907µs ± 0.065µs 10.904µs ± 0.018µs 10.919µs 10.952µs 10.986µs 11.521µs 5.65% 7.210 62.660 0.60% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 86801069.177op/s 91686193.806op/s ± 527315.184op/s 91708533.496op/s ± 147593.530op/s 91880467.021op/s 92151359.676op/s 92262350.442op/s 92336428.836op/s 0.68% -6.982 59.985 0.57% 37286.814op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [206.313µs; 206.390µs] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4845196.495op/s; 4847023.562op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.646µs; 18.656µs] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53601925.825op/s; 53632109.466op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.898µs; 10.916µs] or [-0.083%; +0.083%] None None None
normalization/normalize_name/normalize_name/good throughput [91613112.993op/s; 91759274.619op/s] or [-0.080%; +0.080%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.168µs 161.765µs ± 0.310µs 161.719µs ± 0.132µs 161.864µs 162.224µs 162.682µs 164.375µs 1.64% 3.483 24.423 0.19% 0.022µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.722µs; 161.808µs] or [-0.027%; +0.027%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.586ms 14.650ms ± 0.031ms 14.647ms ± 0.016ms 14.664ms 14.692ms 14.769ms 14.827ms 1.23% 1.801 7.512 0.21% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.646ms; 14.654ms] or [-0.029%; +0.029%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 48.355ms 48.682ms ± 0.679ms 48.577ms ± 0.076ms 48.667ms 48.787ms 53.084ms 54.425ms 12.04% 7.189 53.374 1.39% 0.048ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [48.588ms; 48.776ms] or [-0.193%; +0.193%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.918µs 3.922µs 0.25% -1.078 8.893 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254969258.106op/s 255593098.344op/s ± 175154.187op/s 255595372.035op/s ± 88336.074op/s 255684952.949op/s 255830282.905op/s 255932841.056op/s 256752995.385op/s 0.45% 1.098 9.020 0.07% 12385.271op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.033µs 77.642µs ± 0.344µs 77.622µs ± 0.204µs 77.827µs 78.276µs 78.532µs 78.606µs 1.27% 0.644 0.022 0.44% 0.024µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12721672.681op/s 12879925.151op/s ± 56867.514op/s 12882955.850op/s ± 33870.905op/s 12916701.945op/s 12960725.278op/s 12968711.125op/s 12981497.843op/s 0.76% -0.622 -0.013 0.44% 4021.140op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.635µs 71.145µs ± 0.332µs 71.129µs ± 0.200µs 71.321µs 71.690µs 72.025µs 72.394µs 1.78% 0.748 0.709 0.47% 0.023µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13813264.260op/s 14056092.795op/s ± 65426.178op/s 14058924.880op/s ± 39703.326op/s 14098942.583op/s 14147129.251op/s 14154658.781op/s 14157325.844op/s 0.70% -0.719 0.626 0.46% 4626.329op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.892µs 3.912µs ± 0.003µs 3.911µs ± 0.001µs 3.913µs 3.917µs 3.919µs 3.924µs 0.31% -0.785 12.367 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254862504.371op/s 255628924.411op/s ± 187860.287op/s 255657331.161op/s ± 91244.780op/s 255727179.522op/s 255833391.687op/s 255858276.710op/s 256948078.092op/s 0.50% 0.816 12.552 0.07% 13283.728op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.433µs 67.923µs ± 0.307µs 67.859µs ± 0.207µs 68.126µs 68.471µs 68.672µs 68.900µs 1.53% 0.535 -0.068 0.45% 0.022µs 1 200
credit_card/is_card_number/378282246310005 throughput 14513705.547op/s 14722805.420op/s ± 66405.810op/s 14736330.221op/s ± 44848.105op/s 14764871.790op/s 14820281.115op/s 14825290.746op/s 14829533.015op/s 0.63% -0.512 -0.111 0.45% 4695.600op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.559µs 45.165µs ± 0.229µs 45.193µs ± 0.156µs 45.333µs 45.480µs 45.521µs 45.878µs 1.52% -0.364 -0.122 0.51% 0.016µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21796894.767op/s 22141496.807op/s ± 112704.890op/s 22127318.397op/s ± 76115.503op/s 22211030.582op/s 22341764.269op/s 22438095.165op/s 22442316.423op/s 1.42% 0.390 -0.113 0.51% 7969.439op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.038µs ± 0.011µs 6.037µs ± 0.003µs 6.040µs 6.046µs 6.112µs 6.131µs 1.56% 6.114 43.099 0.19% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 163100022.541op/s 165617489.561op/s ± 306165.887op/s 165647903.735op/s ± 83469.139op/s 165735935.694op/s 165841422.932op/s 165902404.922op/s 165916653.967op/s 0.16% -6.071 42.644 0.18% 21649.198op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.917µs 3.919µs 0.16% -1.572 11.104 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255195504.008op/s 255605284.527op/s ± 179410.523op/s 255605655.956op/s ± 114673.217op/s 255726256.719op/s 255838455.935op/s 255922482.510op/s 256880081.406op/s 0.50% 1.595 11.289 0.07% 12686.240op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.052µs 65.633µs ± 0.112µs 65.624µs ± 0.075µs 65.709µs 65.823µs 65.856µs 65.872µs 0.38% -0.365 2.435 0.17% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15180996.171op/s 15236228.934op/s ± 25972.950op/s 15238229.567op/s ± 17434.774op/s 15254583.292op/s 15271016.299op/s 15278517.233op/s 15372383.944op/s 0.88% 0.387 2.542 0.17% 1836.565op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.941µs 53.015µs ± 0.034µs 53.011µs ± 0.019µs 53.033µs 53.069µs 53.094µs 53.181µs 0.32% 1.057 3.153 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18803560.300op/s 18862482.202op/s ± 12106.302op/s 18863954.755op/s ± 6859.025op/s 18870279.310op/s 18878320.232op/s 18886400.850op/s 18889074.559op/s 0.13% -1.049 3.119 0.06% 856.045op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.892µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.913µs 3.915µs 3.917µs 3.918µs 0.15% -2.260 18.144 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255264187.453op/s 255654924.943op/s ± 163893.916op/s 255650710.543op/s ± 94892.149op/s 255746341.241op/s 255856392.224op/s 255941705.978op/s 256955794.358op/s 0.51% 2.289 18.416 0.06% 11589.050op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.746µs 49.804µs ± 0.029µs 49.800µs ± 0.018µs 49.824µs 49.856µs 49.887µs 49.894µs 0.19% 0.627 0.286 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20042594.002op/s 20078576.462op/s ± 11530.102op/s 20080204.934op/s ± 7370.235op/s 20086267.019op/s 20094036.292op/s 20099344.018op/s 20102191.139op/s 0.11% -0.624 0.280 0.06% 815.301op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.752µs 45.217µs ± 0.179µs 45.228µs ± 0.121µs 45.342µs 45.489µs 45.533µs 45.579µs 0.78% -0.333 -0.509 0.39% 0.013µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21940153.980op/s 22115692.927op/s ± 87649.695op/s 22110427.342op/s ± 58961.521op/s 22173874.742op/s 22274197.028op/s 22323004.897op/s 22345504.990op/s 1.06% 0.349 -0.493 0.40% 6197.769op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.027µs 6.037µs ± 0.011µs 6.036µs ± 0.003µs 6.038µs 6.045µs 6.103µs 6.107µs 1.18% 4.999 27.491 0.18% 0.001µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 163739870.016op/s 165635362.049op/s ± 288280.953op/s 165680002.428op/s ± 71812.521op/s 165753849.284op/s 165831208.142op/s 165872541.852op/s 165914394.581op/s 0.14% -4.975 27.289 0.17% 20384.542op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255568823.658op/s; 255617373.030op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [77.594µs; 77.689µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12872043.861op/s; 12887806.442op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [71.099µs; 71.191µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14047025.356op/s; 14065160.234op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number/37828224631 execution_time [3.912µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255602888.782op/s; 255654960.040op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.881µs; 67.966µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/378282246310005 throughput [14713602.213op/s; 14732008.627op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.133µs; 45.197µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22125876.993op/s; 22157116.621op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.036µs; 6.040µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/x371413321323331 throughput [165575057.913op/s; 165659921.208op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255580419.954op/s; 255630149.100op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.618µs; 65.649µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15232629.333op/s; 15239828.535op/s] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.011µs; 53.020µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18860804.385op/s; 18864160.019op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255632210.823op/s; 255677639.064op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.800µs; 49.808µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20076978.500op/s; 20080174.423op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.193µs; 45.242µs] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22103545.522op/s; 22127840.332op/s] or [-0.055%; +0.055%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.036µs; 6.039µs] or [-0.024%; +0.024%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165595409.081op/s; 165675315.016op/s] or [-0.024%; +0.024%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 241.821ns 255.301ns ± 15.121ns 247.940ns ± 4.741ns 263.321ns 288.558ns 299.551ns 302.192ns 21.88% 1.446 1.171 5.91% 1.069ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.205ns; 257.397ns] or [-0.821%; +0.821%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 12.682ms 13.057ms ± 0.081ms 13.062ms ± 0.041ms 13.102ms 13.178ms 13.230ms 13.250ms 1.44% -1.164 4.400 0.62% 0.006ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [13.046ms; 13.068ms] or [-0.085%; +0.085%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 188.196ns 191.155ns ± 2.673ns 190.784ns ± 1.797ns 192.192ns 195.807ns 199.734ns 202.590ns 6.19% 1.377 2.411 1.39% 0.189ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [190.785ns; 191.526ns] or [-0.194%; +0.194%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.484µs 25.008µs ± 9.492µs 17.861µs ± 0.306µs 33.652µs 42.027µs 42.888µs 70.538µs 294.92% 1.042 1.074 37.86% 0.671µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.693µs; 26.324µs] or [-5.260%; +5.260%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.237µs 89.412µs ± 0.239µs 89.374µs ± 0.050µs 89.436µs 89.593µs 89.892µs 92.419µs 3.41% 10.139 123.202 0.27% 0.017µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [89.379µs; 89.446µs] or [-0.037%; +0.037%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz ce1d7db 1769703869 gyuheon0h/prof-13289-ld-preload_
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.643ms 10.668ms ± 0.013ms 10.666ms ± 0.008ms 10.675ms 10.690ms 10.719ms 10.729ms 0.58% 1.436 3.741 0.12% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.666ms; 10.670ms] or [-0.017%; +0.017%] None None None

Baseline

Omitted due to size.

@dd-octo-sts
Copy link

dd-octo-sts bot commented Jan 4, 2026 •
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 87.83 MB 87.83 MB +0% (+280 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.57 MB 7.57 MB 0% (0 B) 👌
aarch64-apple-darwin
Artifact Baseline Commit Change
/aarch64-apple-darwin/lib/libdatadog_profiling.a 59.48 MB 59.48 MB +0% (+8 B) 👌
/aarch64-apple-darwin/lib/libdatadog_profiling.dylib 8.58 MB 8.58 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 101.57 MB 101.57 MB +0% (+504 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 9.71 MB 9.71 MB +0% (+24 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 20.44 MB 20.44 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 151.28 MB 151.27 MB -0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 817.84 MB 817.84 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 6.51 MB 6.51 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 73.49 KB 73.49 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 20.14 MB 20.14 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 39.52 MB 39.52 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 17.43 MB 17.43 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 154.16 MB 154.15 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 805.63 MB 805.63 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 5.01 MB 5.01 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 74.62 KB 74.62 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 21.47 MB 21.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 37.29 MB 37.29 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 76.08 MB 76.08 MB +0% (+568 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.00 MB 9.00 MB 0% (0 B) 👌
x86_64-apple-darwin
Artifact Baseline Commit Change
/x86_64-apple-darwin/lib/libdatadog_profiling.a 60.79 MB 60.79 MB +0% (+16 B) 👌
/x86_64-apple-darwin/lib/libdatadog_profiling.dylib 9.63 MB 9.63 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 95.67 MB 95.67 MB +0% (+552 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.45 MB 10.45 MB 0% (0 B) 👌

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from c9a32e0 to 5d2087f Compare January 6, 2026 15:46
danielsn
danielsn reviewed Jan 6, 2026
View reviewed changes
@gyuheon0h gyuheon0h changed the title [crashtracking] Add minimal LD preload test for crashtracker collector [WIP][crashtracking] Add minimal LD preload test for crashtracker collector Jan 6, 2026
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from e2ed49c to 677bb4f Compare January 12, 2026 02:34
@gyuheon0h gyuheon0h changed the title [WIP][crashtracking] Add minimal LD preload test for crashtracker collector [crashtracking] Add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title [crashtracking] Add minimal LD preload test for crashtracker collector tests(crashtrackinh): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title tests(crashtrackinh): add minimal LD preload test for crashtracker collector tests(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title tests(crashtracking): add minimal LD preload test for crashtracker collector test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title test(crashtracking): add minimal LD preload test for crashtracker collector [WIP] test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h changed the title [WIP] test(crashtracking): add minimal LD preload test for crashtracker collector test(crashtracking): add minimal LD preload test for crashtracker collector Jan 12, 2026
@gyuheon0h gyuheon0h marked this pull request as ready for review January 12, 2026 21:26
@gyuheon0h gyuheon0h requested review from a team as code owners January 12, 2026 21:26
@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch 3 times, most recently from c8ebe5f to 93c78fb Compare January 14, 2026 19:46
@DataDog DataDog deleted a comment from datadog-datadog-prod-us1 bot Jan 14, 2026
gleocadie
gleocadie approved these changes Jan 29, 2026
View reviewed changes
Copy link
Contributor

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyuheon0h gyuheon0h force-pushed the gyuheon0h/prof-13289-ld-preload_ branch from 6fed733 to ce1d7db Compare January 29, 2026 16:24
@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

📚 Documentation Check Results

⚠️ 991 documentation warning(s) found

📦 libdd-crashtracker - 991 warning(s)

Updated: 2026-01-29 17:00:57 UTC | Commit: d61bdb6 | missing-docs job results

@github-actions
Copy link

github-actions bot commented Jan 29, 2026 •
edited
Loading

🔒 Cargo Deny Results

⚠️ 1 issue(s) found, showing only errors (advisories, bans, sources)

📦 libdd-crashtracker - 1 error(s)

Show output 
error[vulnerability]: Logging user input may result in poisoning logs with ANSI escape sequences
    ┌─ /home/runner/work/libdatadog/libdatadog/Cargo.lock:200:1
    │
200 │ tracing-subscriber 0.3.19 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected
    │
    ├ ID: RUSTSEC-2025-0055
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0055
    ├ Previous versions of tracing-subscriber were vulnerable to ANSI escape sequence injection attacks. Untrusted user input containing ANSI escape sequences could be injected into terminal output when logged, potentially allowing attackers to:
      
      - Manipulate terminal title bars
      - Clear screens or modify terminal display
      - Potentially mislead users through terminal manipulation
      
      In isolation, impact is minimal, however security issues have been found in terminal emulators that enabled an attacker to use ANSI escape sequences via logs to exploit vulnerabilities in the terminal emulator.
      
      This was patched in [PR #3368](https://github.com/tokio-rs/tracing/pull/3368) to escape ANSI control characters from user input.
    ├ Announcement: https://github.com/advisories/GHSA-xwfj-jgwm-7wp5
    ├ Solution: Upgrade to >=0.3.20 (try `cargo update -p tracing-subscriber`)
    ├ tracing-subscriber v0.3.19
      └── (dev) libdd-telemetry v2.0.0
          └── libdd-crashtracker v1.0.0

advisories FAILED, bans ok, sources ok

Updated: 2026-01-29 17:04:09 UTC | Commit: d61bdb6 | dependency-check job results

@gyuheon0h
Copy link
Contributor Author

gyuheon0h commented Jan 29, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Jan 29, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-01-29 16:56:08 UTC ℹ️ Start processing command /merge

2026-01-29 16:57:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 33m (p90).

2026-01-29 17:30:09 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 488418a into main Jan 29, 2026
76 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the gyuheon0h/prof-13289-ld-preload_ branch January 29, 2026 17:30
@ekump ekump mentioned this pull request Feb 4, 2026
Merged
gh-worker-dd-mergequeue-cf854d bot pushed a commit that referenced this pull request Feb 6, 2026
@ekump
ci: use default-pipeline check for gitlab status rather than custom s…
00c1cd7 
…cripts (#1506)

# What does this PR do?

Attempt to fix a potential race condition with the [all-checks](https://github.com/DataDog/libdatadog/blob/b44bb77dc7e7dcfd8e47d9e8c2bbe1d3cfa894f6/.github/workflows/all-checks.yml) workflow and [report_gitlab_CI_status](https://github.com/DataDog/libdatadog/blob/b44bb77dc7e7dcfd8e47d9e8c2bbe1d3cfa894f6/.gitlab-ci.yml#L42)

`report_gitlab_CI_status` is `post` stage and doesn't get created until after dependent jobs run. 
If all gitlab benchmark and github actions successfully complete, but `report_gitlab_CI_status` hasn't been created yet, then all-checks can pass because all-checks doesn't see anything pending.

The `dd-gitlab/default-pipeline` check has been enabled for this repo by ci-infra. This should solve our problems and remove the need for custom scripts. It will pass when the Gitlab pipeline completes. This check will be added to the branch protection rule for main. all-checks will just be used for github steps.

# Motivation

all-checks passed on #1428 , despite tests failing on the alpine builds in gitlab. 

# Additional Notes

Anything else we should know when reviewing?

# How to test the change?

Describe here in detail how the change can be validated.


Co-authored-by: edmund.kump <edmund.kump@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes

@danielsn danielsn Awaiting requested review from danielsn

Assignees

No one assigned

Labels

crashtracker mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gyuheon0h @codecov-commenter @danielsn @gleocadie