Support sending a service tag
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinsba
reviewed
Feb 14, 2020
devinsba
approved these changes
Feb 14, 2020
remeh
suggested changes
Feb 17, 2020
| @@ -140,6 +141,14 @@ public Instance( | |||
| this.refreshBeansPeriod = appConfig.getRefreshBeansPeriod(); | |||
| } | |||
|
|
|||
| this.service = (String) instanceMap.get("service"); | |||
| if ((this.service == null || this.service == "") && initConfig != null) { | |||
There was a problem hiding this comment.
I think it'll be better to do:
if ((this.service == null || this.service.isEmpty()) && initConfig != null) {You may already know but you should not use == with string in Java, if you don't want to go with .isEmpty you should use .equals
| if ((this.service == null || this.service == "") && initConfig != null) { | ||
| this.service = (String) initConfig.get("service"); | ||
| } | ||
| if (this.service != null && this.service != "") { |
There was a problem hiding this comment.
this.service != null && !this.service.isEmpty()
| @@ -667,6 +676,10 @@ private void refreshBeansList() throws IOException { | |||
| } | |||
| tags.add("instance:" + this.instanceName); | |||
|
|
|||
| if (this.service != null && this.service != "") { | |||
There was a problem hiding this comment.
this.service != null && !this.service.isEmpty()
remeh
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to feature the notion of service more prominently for integrations so that we can correlate metrics with logs and traces
See:
DataDog/datadog-agent#4877
DataDog/datadog-agent#4895