Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service option to default configuration #5805

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Add service option to default configuration #5805

merged 2 commits into from
Feb 21, 2020

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 21, 2020

@ofek ofek requested review from a team as code owners February 21, 2020 01:13
@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #5805 into master will decrease coverage by 2.77%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...ts/tooling/configuration/consumers/test_example.py 100% <ø> (ø) ⬆️
vault/tests/common.py 88.88% <0%> (ø) ⬆️
apache/datadog_checks/apache/apache.py 96% <0%> (ø) ⬆️
kong/tests/test_integration_e2e.py 91.66% <0%> (ø) ⬆️
kong/datadog_checks/kong/kong.py 83.67% <0%> (ø) ⬆️
vault/tests/conftest.py 84.14% <0%> (ø) ⬆️
apache/tests/test_apache.py 91.66% <0%> (ø) ⬆️
vault/tests/test_integration.py 88% <0%> (ø) ⬆️
apache/datadog_checks/apache/__about__.py 100% <0%> (ø) ⬆️
..._checks_dev/datadog_checks/dev/tooling/__main__.py 0% <0%> (ø) ⬆️
... and 896 more

ruthnaebeck
ruthnaebeck suggested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review

apache/datadog_checks/apache/data/conf.yaml.example Outdated Show resolved Hide resolved
apache/datadog_checks/apache/data/conf.yaml.example Outdated Show resolved Hide resolved
apache/datadog_checks/apache/data/conf.yaml.example Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/init_config/service.yaml Outdated Show resolved Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/service.yaml Outdated Show resolved Hide resolved
kong/datadog_checks/kong/data/conf.yaml.example Outdated Show resolved Hide resolved
kong/datadog_checks/kong/data/conf.yaml.example Outdated Show resolved Hide resolved
vault/datadog_checks/vault/data/conf.yaml.example Outdated Show resolved Hide resolved
vault/datadog_checks/vault/data/conf.yaml.example Outdated Show resolved Hide resolved
vault/datadog_checks/vault/data/conf.yaml.example Outdated Show resolved Hide resolved
@ofek @ruthnaebeck
Apply suggestions from code review
8a12680 
Co-Authored-By: ruthnaebeck <19349244+ruthnaebeck@users.noreply.github.com>
ruthnaebeck
ruthnaebeck approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ofek ofek merged commit 235f63a into master Feb 21, 2020
@ofek ofek deleted the ofek/service branch February 21, 2020 16:49
@mgarabed mgarabed mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandreYang AlexandreYang AlexandreYang approved these changes

@ruthnaebeck ruthnaebeck ruthnaebeck approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/apache integration/datadog_checks_dev integration/kong integration/vault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofek @ruthnaebeck @AlexandreYang