Upgrade ci to support Python 3 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
Coverage ? 84.62%
=========================================
Files ? 37
Lines ? 852
Branches ? 76
=========================================
Hits ? 721
Misses ? 111
Partials ? 20 |
gzussa
suggested changes
Mar 5, 2019
| envlist = | ||
| reboot_required | ||
| py27-reboot_required | ||
| flake8 | ||
|
|
||
| [testenv] |
There was a problem hiding this comment.
Also let's add platform = linux|darwin|win32 for [flake8]
There was a problem hiding this comment.
exclude = .eggs,.tox,build ?
|
|
||
| [testenv] | ||
| platform = linux|darwin | ||
| deps = | ||
| datadog-checks-base[deps] | ||
| -rrequirements-dev.txt | ||
|
|
| envlist = unit, integration, flake8 | ||
| basepython = py37 | ||
| envlist = | ||
| py27-{unit,integration} |
| envlist = | ||
| reboot_required | ||
| py27-reboot_required |
| envlist = | ||
| sortdb | ||
| py27-sortdb | ||
| flake8 | ||
|
|
||
| [testenv] |
There was a problem hiding this comment.
exclude = .eggs,.tox,build and platform = linux|darwin|win32 for [flake8]
| envlist = | ||
| sortdb | ||
| py27-sortdb |
| envlist = | ||
| unit, | ||
| integration, | ||
| py27-{unit,integration} |
| envlist = | ||
| unit, | ||
| integration, | ||
| py27-{unit,integration} | ||
| flake8 | ||
|
|
||
| [testenv] | ||
| platform = linux|darwin |
There was a problem hiding this comment.
let's run flake on win32 as well here
There was a problem hiding this comment.
and let's exclude build as well
|
I'll address individual Python 3 & platform compatibility in separate PRs |
nmuesch
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DataDog/integrations-core#3243
Also fixed flake8 as was done in ^