Upgrade to Python 3.7 for tests #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3243 +/- ##
=========================================
- Coverage 85.24% 84.7% -0.55%
=========================================
Files 684 694 +10
Lines 36272 37035 +763
Branches 4153 4262 +109
=========================================
+ Hits 30920 31370 +450
- Misses 4164 4393 +229
- Partials 1188 1272 +84 |
Codecov Report
@@ Coverage Diff @@
## master #3243 +/- ##
==========================================
+ Coverage 85.24% 85.35% +0.11%
==========================================
Files 684 684
Lines 36272 36279 +7
Branches 4153 4318 +165
==========================================
+ Hits 30920 30967 +47
+ Misses 4164 4121 -43
- Partials 1188 1191 +3 |
ofek
force-pushed
the
ofek/37
branch
2 times, most recently
from
52ca1f2 to
7fc7bf6
Compare
ofek
added
changelog/no-changelog
integration/all
and removed
changelog/Added
integration/datadog_checks_dev
labels
nmuesch
reviewed
Mar 4, 2019
| @@ -1,15 +1,13 @@ | |||
| [tox] | |||
| minversion = 2.0 | |||
| basepython = py36 | |||
| basepython = py27 | |||
nmuesch
reviewed
Mar 4, 2019
nmuesch
reviewed
Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
🐍 3️⃣
Notes
flake8on 3.7 exposed some things that were not caught on 2.x, for some reason. I fixed those tooNotes
Certificate handling in the
http_checkdoes not work on 3.7 so that still uses 3.6. We'll fix that in a subsequent pr