Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning for snmp generate profile command #9967

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Fix warning for snmp generate profile command #9967

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8a27b5
[ddev] fix warning for snmp generate profile command
AlexandreYang Aug 24, 2021
7410de7
Fix import
AlexandreYang Aug 24, 2021
51509ce
Merge branch 'master' into alex/ddev_fix_warning_for_snmp_generate_pr…
AlexandreYang Aug 26, 2021
288e263
use abort
AlexandreYang Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use abort
  • Loading branch information
@AlexandreYang
AlexandreYang committed Aug 26, 2021
commit 288e26345f9bfcc78c308c32a1a303715741f615
5 changes: 2 additions & 3 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/meta/snmp/generate_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import click
import yaml

from ...console import CONTEXT_SETTINGS, echo_debug, echo_info, echo_warning, set_debug
from ...console import CONTEXT_SETTINGS, abort, echo_debug, echo_info, set_debug


@click.command(context_settings=CONTEXT_SETTINGS, short_help='Generate an SNMP profile from a collection of MIB files')
Expand Down Expand Up @@ -110,8 +110,7 @@ def generate_profile_from_mibs(ctx, mib_files, filters, aliases, debug, interact

# ensure at least one mib file is provided
if len(mib_files) == 0:
echo_warning('🙄 no mib file provided, need at least one mib file to generate a profile')
return
abort('🙄 no mib file provided, need at least one mib file to generate a profile')

# create a list of all mib files directories and mib names
source_directories = set()
Expand Down