Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning for snmp generate profile command #9967

Merged

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Aug 24, 2021

What does this PR do?

fix warning for snmp generate profile command

PR introducing the bug https://github.com/DataDog/integrations-core/pull/9228/files#diff-517fefe8c9e541a2dda6b56a805e749745a8335dbae499ee11bee7614ce734d4R107

Motivation

The command is failing with:

TypeError: echo_warning() got an unexpected keyword argument 'file'

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #9967 (288e263) into master (94d0365) will decrease coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ghost ghost added the integration/snmp label Aug 26, 2021
@AlexandreYang AlexandreYang force-pushed the alex/ddev_fix_warning_for_snmp_generate_profile_command branch from 5e73e42 to 51509ce Compare August 26, 2021 12:26
@AlexandreYang AlexandreYang changed the title [ddev] fix warning for snmp generate profile command [ddev] Fix warning for snmp generate profile command Aug 26, 2021
@AlexandreYang AlexandreYang merged commit 0cbdebf into master Sep 6, 2021
@AlexandreYang AlexandreYang deleted the alex/ddev_fix_warning_for_snmp_generate_profile_command branch September 6, 2021 15:43
@ChristineTChen ChristineTChen changed the title [ddev] Fix warning for snmp generate profile command Fix warning for snmp generate profile command Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants