Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate dashboard and recommended monitors validation #9899

Merged
merged 13 commits into from
Sep 2, 2021
Merged

Annotate dashboard and recommended monitors validation #9899

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad7fd5a
Annotate dashboards
ChristineTChen Aug 13, 2021
c64b8cd
Clean up dashboard test
ChristineTChen Aug 13, 2021
3d3f7b2
Fix style
ChristineTChen Aug 13, 2021
367c56d
Fix import
ChristineTChen Aug 20, 2021
fe617f1
annotate queue
ChristineTChen Aug 30, 2021
5426311
Annotate recommended monitors
ChristineTChen Aug 30, 2021
9955701
test
ChristineTChen Aug 30, 2021
34315bb
Add validation
ChristineTChen Aug 30, 2021
eeb97cc
use basename for dashboard file
ChristineTChen Aug 30, 2021
82ad374
Undo test
ChristineTChen Aug 30, 2021
3219464
Fix style
ChristineTChen Aug 30, 2021
b8d9544
Update datadog_checks_dev/datadog_checks/dev/tooling/commands/validat…
ChristineTChen Aug 31, 2021
2cee006
Fix style'
ChristineTChen Aug 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix style
  • Loading branch information
@ChristineTChen
ChristineTChen committed Aug 30, 2021
commit 3d3f7b2bfe1bb6e009ba5de76198cf4231e9d693
5 changes: 3 additions & 2 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/dashboards.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import json

import click

from datadog_checks.dev.utils import print_github_annotation

from ....utils import read_file
Expand Down Expand Up @@ -53,7 +54,7 @@ def dashboards(check):
message = f'{invalid} does not exist'
echo_info(f'{check_name}... ', nl=False)
echo_info(' FAILED')
echo_failure(f' ' + message)
echo_failure(' ' + message)
failed_checks += 1
print_github_annotation(manifest_file, message)

Expand All @@ -65,7 +66,7 @@ def dashboards(check):
message = f'invalid json: {e}'
echo_info(f'{check_name}... ', nl=False)
echo_failure(' FAILED')
echo_failure(f' ' + message)
echo_failure(' ' + message)
print_github_annotation(dashboard_file, message)
continue

Expand Down