Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate dashboard and recommended monitors validation #9899

Merged
merged 13 commits into from
Sep 2, 2021
Merged

Annotate dashboard and recommended monitors validation #9899

merged 13 commits into from
Sep 2, 2021

Conversation

ChristineTChen
Copy link
Contributor

@ChristineTChen ChristineTChen commented Aug 13, 2021 •
edited
Loading

What does this PR do?

Add dashboard annotations (also uses base name instead of entire file path for message)

Add recommeded monitors annotations.

Motivation

Dashboards

Screen Shot 2021-08-30 at 6 15 04 PM

Recommended Monitors

Screen Shot 2021-08-30 at 6 11 55 PM

alai97
alai97 previously approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs!

@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #9899 (2cee006) into master (99196f5) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

yzhan289
yzhan289 previously approved these changes Aug 16, 2021
View reviewed changes
@ChristineTChen ChristineTChen dismissed stale reviews from yzhan289 and alai97 via a973f82 August 18, 2021 22:24
@ChristineTChen ChristineTChen force-pushed the cc/annotate-assets branch 3 times, most recently from 183bcaf to 3b0b64a Compare August 20, 2021 23:07
@ChristineTChen ChristineTChen requested a review from a team as a code owner August 30, 2021 21:35
@ghost ghost added the integration/coredns label Aug 30, 2021
@ChristineTChen ChristineTChen changed the title Annotate assets Annotate dashboard and recommended monitors validation Aug 30, 2021
@ChristineTChen @ofek
Update datadog_checks_dev/datadog_checks/dev/tooling/commands/validat…
b8d9544 
…e/dashboards.py

Co-authored-by: Ofek Lev <ofekmeister@gmail.com>
@ChristineTChen ChristineTChen requested a review from ofek August 31, 2021 17:59
@ChristineTChen ChristineTChen merged commit 592edc1 into master Sep 2, 2021
@ChristineTChen ChristineTChen deleted the cc/annotate-assets branch September 2, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

@hithwen hithwen hithwen approved these changes

@alai97 alai97 alai97 left review comments

@trishankatdatadog trishankatdatadog Awaiting requested review from trishankatdatadog

@ofek ofek Awaiting requested review from ofek

Assignees
No one assigned
Labels
dev/tooling documentation integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristineTChen @hithwen @ofek @yzhan289 @alai97