Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics option in legacy OpenMetrics example config #9891

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Update metrics option in legacy OpenMetrics example config #9891

merged 2 commits into from
Aug 12, 2021

Conversation

kaitlavs
Copy link
Contributor

The example we share for the metrics: parameter is currently configured wrong. There needs to be a space between the original metric name, and the renamed version or the agent will skip collection.

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@kaitlavs
Update metrics param in OpenMetrics's conf.yaml
a3f9bbf 
The example we share for the metrics: parameter is currently configured wrong. There needs to be a space between the original metric name, and the renamed version or the agent will skip collection.
@kaitlavs kaitlavs requested a review from a team as a code owner August 12, 2021 17:01
@codecov
Copy link

codecov bot commented Aug 12, 2021 •
edited
Loading

Codecov Report

Merging #9891 (af7f7e9) into master (d65d50b) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
datadog_checks_dev 79.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kaitlavs kaitlavs requested a review from a team as a code owner August 12, 2021 18:22
fanny-jiang
fanny-jiang approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@fanny-jiang fanny-jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ofek ofek merged commit 9b8f3d0 into master Aug 12, 2021
@ofek ofek deleted the kaitlavs-openmetrics-format branch August 12, 2021 21:43
@ofek ofek changed the title Update metrics param in OpenMetrics's conf.yaml Update metrics option in legacy OpenMetrics example config Aug 12, 2021
@ofek ofek mentioned this pull request Aug 18, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanny-jiang fanny-jiang fanny-jiang approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev integration/openmetrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlavs @fanny-jiang @ofek