Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics parameter in OpenMetrics's conf.yaml #9783

Closed
wants to merge 1 commit into from

Conversation

kaitlavs
Copy link
Contributor

The example we share for the metrics: parameter is currently configured wrong. There needs to be a space between the original metric name, and the renamed version or the agent will skip collection.

What does this PR do?

Adds a space between the original metric name and the renamed version for the metrics: parameter

Motivation

Two customer escalations

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #9783 (71413d9) into master (d98c2c2) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 71413d9 differs from pull request most recent head 64f7fd0. Consider uploading reports for the commit 64f7fd0 to get more accurate results
| Flag | Coverage Δ | |
|---|---|---|
| avi_vantage | ? | |
| datadog_checks_dev | 79.93% <ø> (ø) | |
| datadog_cluster_agent | ? | |

Flags with carried forward coverage won't be shown. Click here to find out more.

@ChristineTChen ChristineTChen mentioned this pull request Jul 27, 2021
4 tasks
@ofek
Copy link
Contributor

ofek commented Jul 28, 2021

Hi! You'll still need to do this: #9748 (review)

(and rebase)

The example we share for the metrics: parameter is currently configured wrong. There needs to be a space between the original metric name, and the renamed version or the agent will skip collection.
@ofek
Copy link
Contributor

ofek commented Aug 18, 2021

#9891

@ofek ofek closed this Aug 18, 2021
@ofek ofek deleted the kaitlavs-openmetrics branch August 18, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants