Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models validation #8875

Closed
wants to merge 1 commit into from
Closed

Fix models validation #8875

wants to merge 1 commit into from

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

@ofek ofek requested a review from a team as a code owner March 22, 2021 14:01
FlorianVeaux
FlorianVeaux requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, as I mentioned here, datadog_checks_base is already tested on core as it is returned by get_valid_checks.

Why do we need to test it twice in the same method call?

@ofek
Copy link
Contributor Author

ofek commented Mar 22, 2021

local mistake 👍

@ofek ofek closed this Mar 22, 2021
@ofek ofek deleted the ofek/vm branch March 22, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux requested changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofek @FlorianVeaux