Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix models validation #8871

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix models validation #8871

merged 1 commit into from
Mar 22, 2021

Conversation

FlorianVeaux
Copy link
Member

datadog_checks_base is already included in get_valid_checks so we were testing it twice on core.

Also we were testing base on integrations-extras and marketplace which is not possible as the lib is not installed.

@FlorianVeaux FlorianVeaux requested a review from a team as a code owner March 22, 2021 10:44
@FlorianVeaux FlorianVeaux merged commit 8664631 into master Mar 22, 2021
@FlorianVeaux FlorianVeaux deleted the florian/fix_model_validation branch March 22, 2021 13:45
@ofek ofek mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianVeaux @hithwen