Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of Agent deps when using single check #8461

Merged
merged 3 commits into from
Jan 26, 2021
Merged

Fix validation of Agent deps when using single check #8461

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49e1507
Fix validation of Agent deps when using single check
Jan 26, 2021
6cf6366
Update datadog_checks_dev/datadog_checks/dev/tooling/commands/validat…
Jan 26, 2021
66447a5
Apply suggestion from code review, fix black
Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix validation of Agent deps when using single check
  • Loading branch information
Florimond Manca committed Jan 26, 2021
commit 49e15077c92358f1cee33ec849cb04f1724d4eb4
9 changes: 8 additions & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/dep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,14 @@ def dep(check, require_base_check_version, min_base_check_version):
):
failed = True

for name, versions in sorted(agent_dependencies.items()):
agent_dependencies_to_compare = (
agent_dependencies
if check is None
# If validating a single check, whether all Agent dependencies are included in check dependencies is irrelevant.
else {}
)
florimondmanca marked this conversation as resolved.
Show resolved Hide resolved
florimondmanca marked this conversation as resolved.
Show resolved Hide resolved

for name, versions in sorted(agent_dependencies_to_compare.items()):
if not verify_dependency('Agent', name, versions):
failed = True

Expand Down