Fix validation of Agent deps when using single check - #8461
Merged
Conversation
mgarabed
requested changes
Jan 26, 2021
mgarabed
left a comment
Member
There was a problem hiding this comment.
👍 Good update - minor formatting nit.
…e/dep.py Co-authored-by: Mike Garabedian <mike.garabedian@datadoghq.com>
Contributor
Author
|
@mgarabed Sure. 👍 |
ofek
reviewed
Jan 26, 2021
mgarabed
approved these changes
Jan 26, 2021
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix behavior of
ddev validate dep <check>Motivation
Found during QA for #8297
Currently
$ ddev validate dep nginxfails with a large list of errors:This is because when passing a
<check>, we currently still validatecheck_dependencies(which only contains the deps for<check>, rather than the set of all deps for all checks) againstagent_dependencies(which contains all dependencies shipped in the Agent).Instead, I think we should just skip this verification when passing a
<check>. If the dependencies for<check>does contain an out-of-sync dependency compared to Agent deps, then we'll notice during the "all checks" run of this job anyway.With this PR, the validation passes.
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached