Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_distribution_sums_as_monotonic to openmetrics config spec #6247

Merged
merged 2 commits into from
Apr 3, 2020
+9 −2
Merged

Add send_distribution_sums_as_monotonic to openmetrics config spec #6247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
419df49
Sync openmetrics
AlexandreYang Apr 3, 2020
72dae2d
Add send_distribution_sums_as_monotonic
AlexandreYang Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ..._checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/openmetrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
- name: send_distribution_buckets
description: |
Set `send_distribution_buckets` to `true` to send histograms as Datadog distribution metrics.

Learn more about distribution metrics: https://docs.datadoghq.com/developers/metrics/distributions/
value:
example: false
Expand All @@ -103,6 +103,13 @@
value:
example: false
type: boolean
- name: send_distribution_sums_as_monotonic
description: |
Set send_distribution_sums_as_monotonic to true to send histograms & summary
sum as monotonic counters (instead of gauges).
value:
example: false
type: boolean
- name: exclude_labels
description: List of labels to be excluded
value:
Expand Down
2 changes: 1 addition & 1 deletion openmetrics/datadog_checks/openmetrics/data/conf.yaml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ instances:
## Set send_distribution_sums_as_monotonic to true to send histograms & summary
## sum as monotonic counters (instead of gauges).
#
# send_distribution_sums_as_monotonic: true
# send_distribution_sums_as_monotonic: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py

Line 212 in 64c8587

default_instance.get('send_distribution_sums_as_monotonic', False),


## @param exclude_labels - list of strings - optional
## List of labels to be excluded
Expand Down