Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add send_distribution_sums_as_monotonic to openmetrics config spec #6247

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Add send_distribution_sums_as_monotonic to openmetrics config spec #6247

merged 2 commits into from
Apr 3, 2020

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Sync openmetrics config

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@AlexandreYang AlexandreYang requested review from a team as code owners April 3, 2020 15:24
AlexandreYang
AlexandreYang commented Apr 3, 2020
View reviewed changes
openmetrics/datadog_checks/openmetrics/data/conf.yaml.example
@@ -132,7 +132,7 @@ instances:
## Set send_distribution_sums_as_monotonic to true to send histograms & summary
## sum as monotonic counters (instead of gauges).
#
# send_distribution_sums_as_monotonic: true
# send_distribution_sums_as_monotonic: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

integrations-core/datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py

Line 212 in 64c8587

default_instance.get('send_distribution_sums_as_monotonic', False),

@AlexandreYang AlexandreYang changed the title Sync openmetrics config Add send_distribution_sums_as_monotonic to openmetrics config spec Apr 3, 2020
ChristineTChen
ChristineTChen approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexandreYang AlexandreYang merged commit 2a24aad into master Apr 3, 2020
@AlexandreYang AlexandreYang deleted the alex/openmetrics_fix_ci branch April 3, 2020 15:47
@florimondmanca florimondmanca mentioned this pull request Apr 3, 2020
Merged
4 tasks
@florimondmanca florimondmanca mentioned this pull request Apr 3, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

Assignees
No one assigned
Labels
dev/tooling integration/datadog_checks_dev integration/openmetrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreYang @ChristineTChen @florimondmanca