Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use config spec #5979

Merged
merged 6 commits into from
Mar 6, 2020
Merged

Use config spec #5979

merged 6 commits into from
Mar 6, 2020

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Mar 5, 2020 •
edited
Loading

Need #5978 to be merged first

The PR uses alex/jmx_template branch as base.

@AlexandreYang AlexandreYang requested review from a team as code owners March 5, 2020 19:41
@AlexandreYang AlexandreYang mentioned this pull request Mar 5, 2020
Merged
ofek
ofek requested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Need to define logs section too

hive/assets/configuration/spec.yaml Show resolved Hide resolved
@AlexandreYang AlexandreYang changed the base branch from master to alex/jmx_template March 6, 2020 09:21
@AlexandreYang AlexandreYang force-pushed the alex/hive_use_config_spec branch 3 times, most recently from a5412a7 to c582c28 Compare March 6, 2020 15:46
@AlexandreYang AlexandreYang requested review from a team as code owners March 6, 2020 15:46
@AlexandreYang AlexandreYang changed the base branch from alex/jmx_template to master March 6, 2020 15:46
@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited
Loading

Codecov Report

Merging #5979 into master will decrease coverage by 33.71%.
The diff coverage is n/a.

Impacted Files Coverage Δ
mesos_master/tests/test_integration_e2e.py
...ks_base/datadog_checks/base/stubs/datadog_agent.py
gunicorn/datadog_checks/gunicorn/gunicorn.py
vsphere/datadog_checks/vsphere/vsphere.py
directory/tests/test_integration.py
ibm_mq/tests/conftest.py
linkerd/datadog_checks/linkerd/linkerd.py
...g_checks_base/datadog_checks/base/utils/timeout.py
couch/datadog_checks/couch/couch.py
couch/tests/conftest.py
... and 856 more

@AlexandreYang AlexandreYang force-pushed the alex/hive_use_config_spec branch from c582c28 to 57e64c2 Compare March 6, 2020 16:20
AlexandreYang
AlexandreYang commented Mar 6, 2020
View reviewed changes
hive/tests/conftest.py Outdated
@@ -19,4 +19,7 @@ def dd_environment():
log_patterns=[r'datanode:\(\d+\) is available', 'Starting Hive Metastore Server', 'Starting HiveServer2'],
sleep=2,
):
yield load_jmx_config(), {'use_jmx': True}
instance = {'host': 'localhost', 'port': 8809}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be explicit about the instances we are using instead of using the config from conf.example.yaml.

ofek
ofek previously approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@AlexandreYang AlexandreYang merged commit 07c7525 into master Mar 6, 2020
@AlexandreYang AlexandreYang deleted the alex/hive_use_config_spec branch March 6, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/hive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandreYang @ofek