-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config spec templates for JMX integrations #5978
Conversation
Codecov Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💜
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/init_config/jmx.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/init_config/jmx.yaml
Outdated
Show resolved
Hide resolved
required: true | ||
description: JMX port to connect to. | ||
value: | ||
example: 8686 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this standard? If not, let's not put example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8686
seems used quite often for jmx
, not sure it's standard, but it's quite common/typical:
- https://docs.oracle.com/cd/E19528-01/819-4892/ganjx/index.html
- https://www.ibm.com/support/knowledgecenter/en/SSHS8R_8.0.0/com.ibm.worklight.installconfig.doc/install_config/t_optional_config_app_server_tomcat.html
- https://thwack.solarwinds.com/t5/SAM-Documents/Understanding-Java-Remote-JMX-Initial-Setup-Config-Overview/ta-p/529969
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/jmx.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/jmx.yaml
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/jmx.yaml
Outdated
Show resolved
Hide resolved
…uration/init_config/jmx.yaml Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/init_config/jmx.yaml Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
Add jmx default config spec template used for jmx integrations.
Example usage for Hive: #5979