Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config spec templates for JMX integrations #5978

Merged
merged 19 commits into from
Mar 6, 2020
Merged

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Mar 5, 2020

Add jmx default config spec template used for jmx integrations.

Example usage for Hive: #5979

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #5978 into master will decrease coverage by 8.26%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_dev/tests/test_docker.py 48.14% <0.00%> (-51.86%) ⬇️
datadog_checks_dev/tests/tooling/test_utils.py 68.75% <0.00%> (-31.25%) ⬇️
datadog_checks_dev/datadog_checks/dev/env.py 22.72% <0.00%> (-20.46%) ⬇️
datadog_checks_dev/datadog_checks/dev/docker.py 24.57% <0.00%> (-19.50%) ⬇️
datadog_checks_dev/tests/test_conditions.py 82.25% <0.00%> (-17.75%) ⬇️
...atadog_checks_dev/datadog_checks/dev/structures.py 68.85% <0.00%> (-13.12%) ⬇️
datadog_checks_dev/datadog_checks/dev/_env.py 54.79% <0.00%> (-9.59%) ⬇️
...atadog_checks_dev/datadog_checks/dev/subprocess.py 72.97% <0.00%> (-5.41%) ⬇️
...atadog_checks_dev/datadog_checks/dev/conditions.py 80.95% <0.00%> (-4.77%) ⬇️
...er/datadog_checks/openstack_controller/settings.py
... and 718 more

@AlexandreYang AlexandreYang mentioned this pull request Mar 5, 2020
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

required: true
description: JMX port to connect to.
value:
example: 8686
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this standard? If not, let's not put example

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlexandreYang and others added 6 commits March 6, 2020 10:12
…uration/init_config/jmx.yaml

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/init_config/jmx.yaml

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
…uration/instances/jmx.yaml

Co-Authored-By: Ofek Lev <ofekmeister@gmail.com>
@AlexandreYang AlexandreYang merged commit c5cd638 into master Mar 6, 2020
@ofek ofek changed the title Add jmx default config spec template Add config spec templates for JMX integrations Mar 6, 2020
@dd-devflow dd-devflow bot deleted the alex/jmx_template branch February 7, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants