Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ddev release #4783

Closed

Conversation

ogaca-dd
Copy link
Contributor

What does this PR do?

  • Dry mode:
    • Before: dry mode only display git diff output.
    • After: The dry mode is the same as normal mode except it does not create the Trello cards.
  • The diff is computed using remote branches (origin/master instead of master)

Motivation

dry mode: It is nice to see what will be really created.
Using remote branches: the local master branch can be out of date.

Additional Notes

I will recreate a PR once #4765 will be merged (And add the changelog).

We need to check the use cases to see if using remote branches for diff is a good idea or #4775 is better.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.


with chdir(root):
result = run_command('git fetch')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We avoid modifying git state. Perhaps add a confirmation prompt

@stale
Copy link

stale bot commented Nov 15, 2019

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

@stale stale bot added the stale label Nov 15, 2019
@ogaca-dd ogaca-dd mentioned this pull request Nov 27, 2019
4 tasks
@ogaca-dd
Copy link
Contributor Author

Replaced by #5093

@ogaca-dd ogaca-dd closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants