Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddev testable command to properly use the tag, fallback on the branch if absent. #4775

Merged
merged 1 commit into from
Oct 15, 2019

Conversation

remeh
Copy link
Contributor

@remeh remeh commented Oct 15, 2019

What does this PR do?

Fix ddev testable command to properly use the tag (and fallback on the branch if absent).

Motivation

It could use the branch with the same name instead.

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
    - [ ] If PR adds a configuration option, it must be added to the configuration file.

@therve therve merged commit 7a81a2a into master Oct 15, 2019
@therve therve deleted the remeh/ddev-testable branch October 15, 2019 11:40
FlorianVeaux pushed a commit that referenced this pull request Oct 15, 2019
@ogaca-dd ogaca-dd mentioned this pull request Oct 16, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants