Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to create command if name is lowercase #4564

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Add warning to create command if name is lowercase #4564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/commands/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..constants import get_root
from ..create import construct_template_fields, create_template_files, get_valid_templates
from ..utils import normalize_package_name
from .console import CONTEXT_SETTINGS, abort, echo_info, echo_success
from .console import CONTEXT_SETTINGS, abort, echo_info, echo_success, echo_warning

HYPHEN = b'\xe2\x94\x80\xe2\x94\x80'.decode('utf-8')
PIPE = b'\xe2\x94\x82'.decode('utf-8')
Expand Down Expand Up @@ -94,6 +94,10 @@ def display_path_tree(path_tree):
@click.pass_context
def create(ctx, name, integration_type, location, non_interactive, quiet, dry_run):
"""Create scaffolding for a new integration."""

if name.islower():
echo_warning('Make sure to use use display name. e.g. MapR, Ambari, IBM MQ, vSphere, ...')

repo_choice = ctx.obj['repo_choice']
root = resolve_path(location) if location else get_root()
path_sep = os.path.sep
Expand Down