Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to create command if name is lowercase #4564

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Add warning to create command if name is lowercase.

Motivation

If name is lower, that might produce the wrong display_name, public_title, etc for manifest.json

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@AlexandreYang AlexandreYang merged commit 7a721e2 into master Sep 20, 2019
@AlexandreYang AlexandreYang deleted the alex/create_command_warning branch September 20, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants