Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env check for jmx integrations #4146

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Add env check for jmx integrations #4146

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7067381
Add env check for jmx integrations
coignetp Jul 18, 2019
6f0062a
Fix style
coignetp Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix style
  • Loading branch information
@coignetp
coignetp committed Jul 18, 2019
commit 6f0062a8e3909befa5026bf448c9a897d2941691
14 changes: 12 additions & 2 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/env/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,14 @@ def check_run(check, env, rate, times, pause, delay, log_level, as_json, break_p

environment = create_interface(check, env)
check_args = dict(
rate=rate, times=times, pause=pause, delay=delay, log_level=log_level, as_json=as_json, break_point=break_point, jmx_list=jmx_list
rate=rate,
times=times,
pause=pause,
delay=delay,
log_level=log_level,
as_json=as_json,
break_point=break_point,
jmx_list=jmx_list,
)

if config_file:
Expand All @@ -70,4 +77,7 @@ def check_run(check, env, rate, times, pause, delay, log_level, as_json, break_p

if not rate:
echo_success('Note: ', nl=False)
echo_info('If some metrics are missing, you may want to try again with the -r / --rate flag for a classic integration.')
echo_info(
'If some metrics are missing, you may want to try again with the -r / --rate flag '
'for a classic integration.'
)
2 changes: 1 addition & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/e2e/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def run_check(
command += ' --breakpoint {}'.format(break_point)

if log_level is not None:
command += ' --log-level {}'.format(log_level)
command += ' --log-level {}'.format(log_level)

return self.exec_command(command, capture=capture, interactive=break_point is not None)

Expand Down
2 changes: 1 addition & 1 deletion datadog_checks_dev/datadog_checks/dev/tooling/e2e/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def run_check(
command += ' --breakpoint {}'.format(break_point)

if log_level is not None:
command += ' --log-level {}'.format(log_level)
command += ' --log-level {}'.format(log_level)

return run_command(command, capture=capture)

Expand Down