Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env check for jmx integrations #4146

Merged
merged 2 commits into from
Jul 24, 2019
Merged

Add env check for jmx integrations #4146

merged 2 commits into from
Jul 24, 2019

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Add the possibility to use ddev env check integ env for JMX integration.
It uses datadog-agent jmx list [...]. The default list method is matching, but it can be set using --jmx-list.

Motivation

Using ddev env check jmx_integ py37-latest for JMX integration like the classic ones.

Additional Notes

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • Feature or bugfix must have tests
  • Git history must be clean
  • If PR adds a configuration option, it must be added to the configuration file.

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #4146 into master will decrease coverage by 4.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4146      +/-   ##
==========================================
- Coverage   82.24%   78.17%   -4.07%     
==========================================
  Files         148       34     -114     
  Lines        7517     1306    -6211     
  Branches      876      134     -742     
==========================================
- Hits         6182     1021    -5161     
+ Misses       1150      254     -896     
+ Partials      185       31     -154

Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just checked it on hive and works as expected 👍

@coignetp coignetp merged commit 22cbd6d into master Jul 24, 2019
@coignetp coignetp deleted the paul/ddev-env-jmx branch July 24, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants