Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pywin32 dependency #2322

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Pin pywin32 dependency #2322

merged 3 commits into from
Oct 1, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 29, 2018

Motivation

Move toward defining all requirements in -core itself rather than the build system

@codecov-io
Copy link

Codecov Report

Merging #2322 into master will decrease coverage by 23.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2322      +/-   ##
==========================================
- Coverage   85.87%   62.77%   -23.1%     
==========================================
  Files         192       42     -150     
  Lines       13463     2598   -10865     
  Branches     1452      442    -1010     
==========================================
- Hits        11561     1631    -9930     
+ Misses       1487      836     -651     
+ Partials      415      131     -284

Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested the build yet? does it work? we need to do that before we merge this

@ofek
Copy link
Contributor Author

ofek commented Sep 30, 2018

I did test windows service and sqlserver manually using the new builds, not the others. Though if those work I'm not sure how I could test the others in such a way that would expose anything the tests haven't.

Also, I still need to actually remove the omnibus dep definition after this is merged.

@ofek ofek merged commit 581d6a2 into master Oct 1, 2018
@ofek ofek deleted the ofek/pywin32 branch October 1, 2018 15:12
nmuesch pushed a commit that referenced this pull request Nov 1, 2018
* Pin pywin32 dependency

* fix conditional sqlserver dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants