-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pywin32 dependency #2322
Pin pywin32 dependency #2322
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2322 +/- ##
==========================================
- Coverage 85.87% 62.77% -23.1%
==========================================
Files 192 42 -150
Lines 13463 2598 -10865
Branches 1452 442 -1010
==========================================
- Hits 11561 1631 -9930
+ Misses 1487 836 -651
+ Partials 415 131 -284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested the build yet? does it work? we need to do that before we merge this
I did test windows service and sqlserver manually using the new builds, not the others. Though if those work I'm not sure how I could test the others in such a way that would expose anything the tests haven't. Also, I still need to actually remove the omnibus dep definition after this is merged. |
* Pin pywin32 dependency * fix conditional sqlserver dep
Motivation
Move toward defining all requirements in -core itself rather than the build system