Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pywin32 dependency from omnibus #2388

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Remove pywin32 dependency from omnibus #2388

merged 1 commit into from
Oct 2, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 30, 2018

Motivation

Move toward defining all requirements in integrations-core itself rather than the build system

Additional Notes

DataDog/integrations-core#2322

@ofek ofek requested a review from a team as a code owner September 30, 2018 17:58
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please confirm the resulting windows MSI ships the desired version of pywin32

@ofek
Copy link
Contributor Author

ofek commented Oct 2, 2018

It does indeed!

@ofek ofek merged commit 62c55a9 into master Oct 2, 2018
@ofek ofek deleted the ofek/pywin32 branch October 2, 2018 19:21
@hush-hush hush-hush added this to the 6.6.0 milestone Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants