Don't abort on ddev release show changes
when no changes are found
#15932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops
ddev release show changes
from aborting when no changes have been found, so that it retains behavior that other commands rely upon.Motivation
AITS-247
Aborting causes the application to exit regardless of context, which is a problem when that breaks expectations of other commands that rely on invoking this command directly.
This was causing
release make all
to abort early as soon as an integration didn't have a change. This regression was introduced in #15378; we weren't aborting under that scenario before.Additional Notes
Longer term, I think we should try to avoid invoking commands from within any sort of minimally complex logic, and be careful with where we call functions that can exit the interpreter completely. We can leave this as it is for now until we move this to the
ddev
package. There's also a couple of unused options that could be removed when we do that as well.Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.