Skip to content

Commit

Permalink
Don't abort on ddev release show changes when no changes are found (#…
Browse files Browse the repository at this point in the history
…15932)

* Don't abort when no changes are found

Aborting causes the application to exit regardless of context, which
is a problem when that breaks expectations of other commands that rely
on invoking this command directly.

* Add changelog
  • Loading branch information
alopezz authored Sep 29, 2023
1 parent ac52e8b commit ede5af1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions datadog_checks_dev/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
* Exclude psycopg2 from automatic upgrades ([#15864](https://github.com/DataDog/integrations-core/pull/15864))
* Upper-bound pydantic to quickly fix CI while we investigate what in the latest version breaks us. ([#15901](https://github.com/DataDog/integrations-core/pull/15901))
* Finalize pytest plugin logic for E2E refactor ([#15898](https://github.com/DataDog/integrations-core/pull/15898))
* Fix `ddev release make all` so that it won't stop on the first unchanged integration ([#15932](https://github.com/DataDog/integrations-core/pull/15932))

## 25.1.0 / 2023-09-15

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from ...console import (
CONTEXT_SETTINGS,
abort,
echo_failure,
validate_check_arg,
)

Expand Down Expand Up @@ -59,7 +60,8 @@ def changes(ctx, check, tag_pattern, tag_prefix, dry_run, organization, since, e
break

if header_index == 4:
abort('There are no changes for this integration')
echo_failure('There are no changes for this integration')
return cur_version, []

unreleased = log[4:header_index]
applicable_changelog_types = []
Expand Down

0 comments on commit ede5af1

Please sign in to comment.