Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump datadog-checks-dev version to ~=24.0 #15683

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Bump datadog-checks-dev version to ~=24.0 #15683

merged 2 commits into from
Aug 29, 2023

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Aug 24, 2023 •
edited
Loading

What does this PR do?

Bump datadog-checks-dev version to ~=24.0

Motivation

I needed #15586 that is shipped in 24.*

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

@FlorentClarret FlorentClarret requested a review from a team as a code owner August 24, 2023 13:39
@ghost ghost added the ddev label Aug 24, 2023
@FlorentClarret FlorentClarret changed the title Bump datadog check base version to ~=24.0 Bump datadog check dev version to ~=24.0 Aug 24, 2023
@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/bump_dcd branch from 7f5dfe5 to d85e5d2 Compare August 24, 2023 13:41
@FlorentClarret FlorentClarret requested a review from a team as a code owner August 24, 2023 13:41
@ghost ghost added the documentation label Aug 24, 2023
@FlorentClarret FlorentClarret added the qa/skip-qa Automatically skip this PR for the next QA label Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Merging #15683 (3c11f74) into master (441957c) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
ddev 99.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

vivek-datadog
vivek-datadog previously approved these changes Aug 24, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

Test Results

    2 files      2 suites   4m 12s ⏱️
314 tests 309 ✔️   5 💤 0 ❌
628 runs  608 ✔️ 20 💤 0 ❌

Results for commit 3c11f74.

♻️ This comment has been updated with latest results.

@jhgilbert jhgilbert self-assigned this Aug 24, 2023
jhgilbert
jhgilbert previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with minor feedback. Thanks!

ddev/CHANGELOG.md Outdated Show resolved Hide resolved
@jhgilbert jhgilbert removed their assignment Aug 24, 2023
@FlorentClarret FlorentClarret dismissed stale reviews from jhgilbert and vivek-datadog via ff2db55 August 25, 2023 06:16
@FlorentClarret FlorentClarret changed the title Bump datadog check dev version to ~=24.0 Bump datadog-checks-dev version to ~=24.0 Aug 25, 2023
@FlorentClarret FlorentClarret force-pushed the florentclarret/ddev/bump_dcd branch from 785b282 to 3c11f74 Compare August 29, 2023 05:55
@FlorentClarret FlorentClarret merged commit 2e06f64 into master Aug 29, 2023
@FlorentClarret FlorentClarret deleted the florentclarret/ddev/bump_dcd branch August 29, 2023 13:49
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
@FlorentClarret
Bump datadog-checks-dev version to ~=24.0 (#15683)
c65d24d 
* Bump datadog check dev version to ~=24.0

* changelog 2e06f64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzhan289 yzhan289 yzhan289 approved these changes

@jhgilbert jhgilbert jhgilbert left review comments

@vivek-datadog vivek-datadog Awaiting requested review from vivek-datadog

Assignees
No one assigned
Labels
ddev documentation qa/skip-qa Automatically skip this PR for the next QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorentClarret @jhgilbert @yzhan289 @vivek-datadog