-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print the metric list when parsing a prometheus endpoint #15586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentClarret
force-pushed
the
florentclarret/dcd/prom_metric_list
branch
from
August 16, 2023 12:37
1d4a73f
to
328518a
Compare
ghost
added
the
documentation
label
Aug 16, 2023
FlorentClarret
force-pushed
the
florentclarret/dcd/prom_metric_list
branch
from
August 16, 2023 12:53
328518a
to
b357c27
Compare
alopezz
previously approved these changes
Aug 16, 2023
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
steveny91
previously approved these changes
Aug 16, 2023
buraizu
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approving with a minor update to the changelog
FlorentClarret
dismissed stale reviews from buraizu, steveny91, and alopezz
via
August 17, 2023 05:40
d240f61
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
FlorentClarret
force-pushed
the
florentclarret/dcd/prom_metric_list
branch
from
August 17, 2023 05:52
d240f61
to
971dadd
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Print the metric list when parsing a prometheus endpoint
Motivation
We use this list in the tests
Before:
After:
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.