Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --memray-show-report option #13463

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Remove the --memray-show-report option #13463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datadog_checks_dev/datadog_checks/dev/plugin/pytest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def pytest_collection_modifyitems(config, items):
return

if PY2:
for option in ("--memray", "--hide-memray-summary"):
for option in ("--memray",):
if config.getoption(option):
warnings.warn("`{}` option ignored as it's not supported for py2 environments.".format(option))

Expand Down
3 changes: 0 additions & 3 deletions datadog_checks_dev/datadog_checks/dev/tooling/commands/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
@click.option('--force-base-min', is_flag=True, help='Force using lowest viable release version of datadog-checks-base')
@click.option('--force-env-rebuild', is_flag=True, help='Force creating a new env')
@click.option('--memray', is_flag=True, help='Run memray to measure memory usage on all tests')
@click.option('--memray-show-report', is_flag=True, help='Print the memray report at the end of the test suite')
@click.pass_context
def test(
ctx,
Expand Down Expand Up @@ -79,7 +78,6 @@ def test(
force_base_min,
force_env_rebuild,
memray,
memray_show_report,
):
"""Run tests for Agent-based checks.

Expand Down Expand Up @@ -204,7 +202,6 @@ def test(
e2e=e2e,
ddtrace=ddtrace_check,
memray=memray,
memray_show_report=memray_show_report,
)
if coverage:
pytest_options = pytest_options.format(pytest_coverage_sources(check))
Expand Down
4 changes: 0 additions & 4 deletions datadog_checks_dev/datadog_checks/dev/tooling/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ def construct_pytest_options(
e2e=False,
ddtrace=False,
memray=False,
memray_show_report=False,
):
# Prevent no verbosity
pytest_options = f'--verbosity={verbose or 1}'
Expand Down Expand Up @@ -566,9 +565,6 @@ def construct_pytest_options(

pytest_options += ' --memray'

if not memray_show_report:
pytest_options += ' --hide-memray-summary'

if marker:
pytest_options += f' -m "{marker}"'

Expand Down