Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --memray-show-report option #13463

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Drop the --memray-show-report option

Motivation

Following this PR and the new pytest-memray version, we do not need to explicitly enable memray for the unit tests and the report will be hidden by default. Manually running them and get the reports can still be useful though. To do that we would run ddev test impala --memray for instance to get the reports, but in this case there's no need to keep the old --hide-memray-summary.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached
  • If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #13463 (c17cc44) into master (e4869c8) will increase coverage by 0.10%.
The diff coverage is n/a.

Flag Coverage Δ
active_directory 100.00% <ø> (+17.64%) ⬆️
activemq_xml 82.31% <ø> (ø)
amazon_msk 88.67% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.08% <ø> (ø)
arangodb 98.21% <ø> (ø)
argocd 88.13% <ø> (ø)
aspdotnet 100.00% <ø> (+26.19%) ⬆️
avi_vantage 92.50% <ø> (ø)
azure_iot_edge 82.00% <ø> (ø)
boundary 100.00% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 87.90% <ø> (ø)
calico 83.33% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
cisco_aci 95.27% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 90.78% <ø> (ø)
coredns 94.54% <ø> (ø)
couch 95.19% <ø> (+0.24%) ⬆️
couchbase 83.58% <ø> (ø)
crio 89.79% <ø> (ø)
datadog_checks_base 89.78% <ø> (+0.33%) ⬆️
datadog_checks_dev 81.57% <ø> (+0.07%) ⬆️
datadog_checks_downloader 78.64% <ø> (+0.99%) ⬆️
datadog_cluster_agent 90.00% <ø> (ø)
ddev 98.77% <ø> (ø)
disk 89.53% <ø> (-2.17%) ⬇️
dns_check 93.90% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 80.05% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
envoy 94.00% <ø> (-0.23%) ⬇️
external_dns 89.09% <ø> (ø)
fluentd 94.77% <ø> (ø)
foundationdb 83.88% <ø> (ø)
go_expvar 92.73% <ø> (ø)
harbor 80.04% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 89.74% <ø> (ø)
ibm_ace 91.79% <ø> (ø)
ibm_db2 95.10% <ø> (ø)
ibm_i 81.95% <ø> (ø)
ibm_mq 91.08% <ø> (ø)
impala 97.97% <ø> (ø)
istio 77.65% <ø> (+0.55%) ⬆️
kong 87.56% <ø> (ø)
kube_controller_manager 96.00% <ø> (ø)
kube_metrics_server 96.87% <ø> (ø)
kube_proxy 98.38% <ø> (ø)
kube_scheduler 96.53% <ø> (ø)
kubelet 90.96% <ø> (ø)
kubernetes_state 89.18% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.70% <ø> (ø)
marathon 83.12% <ø> (ø)
mcache 93.26% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
nagios 89.01% <ø> (ø)
network 93.92% <ø> (+0.95%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx_ingress_controller 98.36% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.90% <ø> (ø)
openstack_controller 90.94% <ø> (ø)
pgbouncer 91.33% <ø> (ø)
php_fpm 90.25% <ø> (+0.84%) ⬆️
postfix 88.04% <ø> (ø)
powerdns_recursor 96.65% <ø> (ø)
process 85.36% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
rabbitmq 94.41% <ø> (ø)
redisdb 87.50% <ø> (ø)
rethinkdb 97.93% <ø> (ø)
riakcs 93.61% <ø> (ø)
silk 93.33% <ø> (ø)
snowflake 96.47% <ø> (ø)
squid 100.00% <ø> (ø)
statsd 87.36% <ø> (+1.05%) ⬆️
system_core 92.85% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 91.58% <ø> (ø)
teradata 94.24% <ø> (ø)
tls 91.82% <ø> (+0.84%) ⬆️
traffic_server 96.13% <ø> (ø)
twemproxy 79.45% <ø> (ø)
twistlock 79.62% <ø> (ø)
win32_event_log 86.68% <ø> (+0.55%) ⬆️
wmi_check 92.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@FlorentClarret FlorentClarret merged commit d832a66 into master Dec 7, 2022
@FlorentClarret FlorentClarret deleted the florentclarret/memray/rmeove-option branch December 7, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants