Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uncommented parent options #12013

Merged
merged 1 commit into from
May 12, 2022
Merged

Fix uncommented parent options #12013

merged 1 commit into from
May 12, 2022

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Fixes uncommented parent config options that should be commented out (these options are disabled by default in their respective spec.yaml).

Motivation

#11707

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@fanny-jiang fanny-jiang requested review from a team as code owners May 12, 2022 17:01
@fanny-jiang fanny-jiang mentioned this pull request May 12, 2022
Closed
4 tasks
@fanny-jiang fanny-jiang merged commit 6aa3ff1 into master May 12, 2022
@fanny-jiang fanny-jiang deleted the fanny/sync-parent-opts branch May 12, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@djova djova djova approved these changes

Assignees
No one assigned
Labels
integration/mysql integration/postgres integration/sqlserver integration/vsphere
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanny-jiang @djova @sarah-witt