Fix enabled for parent options
#11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
fanny-jiang
force-pushed
the
fanny/ddev_spec
branch
from
a1bc90a to
ee0d719
Compare
|
The |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
4 tasks
hithwen
reviewed
Mar 22, 2022
| @@ -183,7 +183,11 @@ def write_option(option, writer, indent='', start_list=False): | |||
| multiple = option['multiple'] | |||
| multiple_instances_defined = option.get('multiple_instances_defined') | |||
|
|
|||
| writer.write(indent, option_name, ':', '\n') | |||
| if not option_enabled(option): | |||
There was a problem hiding this comment.
shouldn't it be true by default?
There was a problem hiding this comment.
It seems for the other non-nested options that if the option is not explicitly enabled, it is commented out: options with a value option and sections with an example option
ofek
approved these changes
May 11, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
enabledoption for parent config options. Previously,enabled: falsewas not getting taken into account.Motivation
Bug
Additional Notes
The
enabledoption value does not propagate to the nested options.enabledwould still need to be configured for the nested options, if applicable.Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached