Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery options to ddev env check command #11044

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jan 6, 2022

What does this PR do?

Add discovery options to check command

Motivation

Needed for e2e testing listeners (snmp listener) that schedules multiple check instances.

Needed for #11055

Additional Notes

Agent PR: DataDog/datadog-agent#10448

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #11044 (9ca116f) into master (4360e46) will increase coverage by 0.30%.
The diff coverage is n/a.

❗ Current head 9ca116f differs from pull request most recent head 9caa821. Consider uploading reports for the commit 9caa821 to get more accurate results
| Flag | Coverage Δ | |
|---|---|---|
| active_directory | 100.00% <ø> (+17.64%) | ⬆️ |
| activemq_xml | 82.31% <ø> (ø) | |
| aerospike | 86.97% <ø> (+0.36%) | ⬆️ |
| airflow | 90.00% <ø> (ø) | |
| amazon_msk | 88.83% <ø> (ø) | |
| ambari | 85.75% <ø> (ø) | |
| apache | 95.08% <ø> (ø) | |
| aspdotnet | 100.00% <ø> (+26.19%) | ⬆️ |
| avi_vantage | 91.92% <ø> (ø) | |
| azure_iot_edge | 82.00% <ø> (ø) | |
| btrfs | 82.91% <ø> (ø) | |
| cacti | 83.95% <ø> (ø) | |
| cassandra_nodetool | 94.19% <ø> (ø) | |
| ceph | 91.02% <ø> (ø) | |
| cilium | 89.74% <ø> (+1.02%) | ⬆️ |
| cisco_aci | 95.83% <ø> (ø) | |
| citrix_hypervisor | 87.50% <ø> (ø) | |
| clickhouse | 95.63% <ø> (ø) | |
| cloud_foundry_api | 95.98% <ø> (+0.12%) | ⬆️ |
| cockroachdb | 100.00% <ø> (ø) | |
| consul | 91.74% <ø> (ø) | |
| coredns | 95.74% <ø> (ø) | |
| couch | 95.19% <ø> (+0.24%) | ⬆️ |
| couchbase | 83.46% <ø> (ø) | |
| crio | 89.79% <ø> (ø) | |
| datadog_checks_base | 90.28% <ø> (+0.35%) | ⬆️ |
| datadog_checks_dev | 80.14% <ø> (ø) | |
| datadog_checks_downloader | 80.64% <ø> (ø) | |
| datadog_cluster_agent | 90.00% <ø> (ø) | |
| directory | 94.87% <ø> (ø) | |
| disk | 91.61% <ø> (ø) | |
| dns_check | 93.84% <ø> (ø) | |
| dotnetclr | 94.93% <ø> (+15.18%) | ⬆️ |
| druid | 97.70% <ø> (ø) | |
| ecs_fargate | 80.23% <ø> (ø) | |
| eks_fargate | 94.05% <ø> (ø) | |
| elastic | 90.52% <ø> (ø) | |
| envoy | 94.25% <ø> (ø) | |
| etcd | 93.87% <ø> (ø) | |
| exchange_server | 98.29% <ø> (+12.82%) | ⬆️ |
| external_dns | 89.09% <ø> (ø) | |
| fluentd | 94.77% <ø> (ø) | |
| gearmand | 78.26% <ø> (+1.24%) | ⬆️ |
| gitlab | 89.94% <ø> (ø) | |
| gitlab_runner | 91.94% <ø> (ø) | |
| glusterfs | 80.09% <ø> (+0.92%) | ⬆️ |
| go_expvar | 92.73% <ø> (ø) | |
| gunicorn | 93.60% <ø> (+0.75%) | ⬆️ |
| haproxy | 95.09% <ø> (+0.16%) | ⬆️ |
| harbor | 81.29% <ø> (ø) | |
| hazelcast | 92.39% <ø> (ø) | |
| hdfs_datanode | 89.74% <ø> (ø) | |
| hdfs_namenode | 86.72% <ø> (ø) | |
| http_check | 90.98% <ø> (+1.74%) | ⬆️ |
| ibm_db2 | 94.84% <ø> (ø) | |
| ibm_i | 80.65% <ø> (ø) | |
| ibm_mq | 89.67% <ø> (ø) | |
| ibm_was | 96.06% <ø> (ø) | |
| iis | 94.91% <ø> (+38.49%) | ⬆️ |
| istio | 77.46% <ø> (+0.56%) | ⬆️ |
| kafka_consumer | 82.66% <ø> (ø) | |
| kong | 88.58% <ø> (ø) | |
| kube_apiserver_metrics | 97.67% <ø> (ø) | |
| kube_controller_manager | 96.85% <ø> (ø) | |
| kube_dns | 98.85% <ø> (ø) | |
| kube_metrics_server | 100.00% <ø> (ø) | |
| kube_proxy | 100.00% <ø> (ø) | |
| kube_scheduler | 96.20% <ø> (ø) | |
| kubelet | 89.63% <ø> (ø) | |
| kyototycoon | 85.96% <ø> (ø) | |
| lighttpd | 83.64% <ø> (ø) | |
| linkerd | 85.14% <ø> (+1.14%) | ⬆️ |
| linux_proc_extras | 96.22% <ø> (ø) | |
| mapr | 82.70% <ø> (ø) | |
| mapreduce | 81.77% <ø> (+0.46%) | ⬆️ |
| marathon | 83.12% <ø> (ø) | |
| marklogic | 95.33% <ø> (ø) | |
| mcache | 93.52% <ø> (ø) | |
| mesos_master | 90.68% <ø> (ø) | |
| mesos_slave | 93.63% <ø> (ø) | |
| mongo | 94.54% <ø> (+0.27%) | ⬆️ |
| mysql | 87.21% <ø> (+0.16%) | ⬆️ |
| nagios | 89.53% <ø> (ø) | |
| network | 77.76% <ø> (+1.00%) | ⬆️ |
| nfsstat | 95.20% <ø> (ø) | |
| nginx | 95.27% <ø> (+0.55%) | ⬆️ |
| nginx_ingress_controller | 98.36% <ø> (ø) | |
| openldap | 96.33% <ø> (ø) | |
| openmetrics | 97.14% <ø> (ø) | |
| openstack | 51.45% <ø> (ø) | |
| openstack_controller | 90.74% <ø> (ø) | |
| oracle | 92.58% <ø> (+2.69%) | ⬆️ |
| pdh_check | 95.65% <ø> (ø) | |
| pgbouncer | 90.45% <ø> (ø) | |
| php_fpm | 90.25% <ø> (+0.84%) | ⬆️ |
| postfix | 88.04% <ø> (ø) | |
| postgres | 91.55% <ø> (+0.21%) | ⬆️ |
| powerdns_recursor | 96.65% <ø> (ø) | |
| process | 85.07% <ø> (+0.28%) | ⬆️ |
| prometheus | 94.17% <ø> (ø) | |
| proxysql | 98.97% <ø> (ø) | |
| rabbitmq | 94.40% <ø> (ø) | |
| redisdb | 87.44% <ø> (ø) | |
| rethinkdb | 97.93% <ø> (ø) | |
| riak | 99.22% <ø> (ø) | |
| riakcs | 93.61% <ø> (ø) | |
| sap_hana | 92.39% <ø> (ø) | |
| scylla | 100.00% <ø> (ø) | |
| singlestore | 90.81% <ø> (ø) | |
| snmp | 87.83% <ø> (+0.04%) | ⬆️ |
| snowflake | 93.60% <ø> (ø) | |
| sonarqube | 95.69% <ø> (ø) | |
| spark | 93.55% <ø> (ø) | |
| sqlserver | 84.27% <ø> (ø) | |
| squid | 100.00% <ø> (ø) | |
| ssh_check | 91.58% <ø> (ø) | |
| statsd | 87.36% <ø> (+4.21%) | ⬆️ |
| supervisord | 92.30% <ø> (ø) | |
| system_core | 91.04% <ø> (ø) | |
| system_swap | 98.30% <ø> (ø) | |
| tcp_check | 89.83% <ø> (ø) | |
| teamcity | 80.00% <ø> (ø) | |
| tls | 97.04% <ø> (+0.87%) | ⬆️ |
| tokumx | 58.40% <ø> (?) | |
| twemproxy | 78.33% <ø> (ø) | |
| twistlock | 79.62% <ø> (ø) | |
| varnish | 84.57% <ø> (+0.24%) | ⬆️ |
| vault | 95.04% <ø> (+0.55%) | ⬆️ |
| vertica | 92.33% <ø> (ø) | |
| voltdb | 96.81% <ø> (ø) | |
| vsphere | 89.78% <ø> (+0.08%) | ⬆️ |
| win32_event_log | 86.32% <ø> (+0.56%) | ⬆️ |
| windows_performance_counters | 98.36% <ø> (ø) | |
| windows_service | 95.83% <ø> (ø) | |
| wmi_check | 92.91% <ø> (ø) | |
| yarn | 89.85% <ø> (ø) | |
| zk | 86.04% <ø> (+0.46%) | ⬆️ |

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@AlexandreYang AlexandreYang changed the title Add discovery options to check command Add discovery options to ddev check command Jan 7, 2022
FlorianVeaux
FlorianVeaux previously approved these changes Jan 7, 2022
Copy link
Member

@FlorianVeaux FlorianVeaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let agent-integrations review as well, but looks great!

Co-authored-by: Paul <paul.coignet@datadoghq.com>
@coignetp coignetp merged commit 39bccb4 into master Jan 7, 2022
@coignetp coignetp deleted the alex/add_discovery_options_to_check_command branch January 7, 2022 11:13
github-actions bot pushed a commit that referenced this pull request Jan 7, 2022
* Add discovery options to check command

* rename command

* min instances

* Apply suggestions from code review

Co-authored-by: Paul <paul.coignet@datadoghq.com>

Co-authored-by: Paul <paul.coignet@datadoghq.com> 39bccb4
@yzhan289 yzhan289 changed the title Add discovery options to ddev check command Add discovery options to ddev env check command Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants