-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add discovery options to ddev env check
command
#11044
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will let agent-integrations review as well, but looks great!
datadog_checks_dev/datadog_checks/dev/tooling/commands/env/check.py
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/env/check.py
Outdated
Show resolved
Hide resolved
datadog_checks_dev/datadog_checks/dev/tooling/commands/env/check.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Paul <paul.coignet@datadoghq.com>
* Add discovery options to check command * rename command * min instances * Apply suggestions from code review Co-authored-by: Paul <paul.coignet@datadoghq.com> Co-authored-by: Paul <paul.coignet@datadoghq.com> 39bccb4
ddev env check
command
What does this PR do?
Add discovery options to check command
Motivation
Needed for e2e testing listeners (snmp listener) that schedules multiple check instances.
Needed for #11055
Additional Notes
Agent PR: DataDog/datadog-agent#10448
Review checklist (to be filled by reviewers)
changelog/
andintegration/
labels attached