Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands/check] Add --discovery-instances option to agent check command #10448

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Jan 6, 2022

What does this PR do?

Add discovery-instances option to agent check command

Currently, the agent check command waits for at least 1 check instance.
If discovery-instances is used, the agent check will wait for at least the specified number of check instances.

Motivation

Needed for e2e testing listeners (snmp listener) that schedules multiple check instances.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • The appropriate team/.. label has been applied, if known.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@AlexandreYang AlexandreYang added this to the 7.34.0 milestone Jan 6, 2022
@AlexandreYang AlexandreYang marked this pull request as ready for review January 6, 2022 15:35
@AlexandreYang AlexandreYang requested a review from a team as a code owner January 6, 2022 15:35
@AlexandreYang AlexandreYang changed the title Add discovery-retry-check-count option to agent check command Add discovery-check-count option to agent check command Jan 6, 2022
@AlexandreYang AlexandreYang added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. team/containers labels Jan 6, 2022
@AlexandreYang AlexandreYang force-pushed the alex/discovery-retry-check-count branch from ee3a209 to 005b470 Compare January 6, 2022 16:02
@AlexandreYang AlexandreYang changed the title Add discovery-check-count option to agent check command [commands/check] Add discovery-check-count option to agent check command Jan 6, 2022
@AlexandreYang AlexandreYang changed the title [commands/check] Add discovery-check-count option to agent check command [commands/check] Add discovery-instances-count option to agent check command Jan 6, 2022
@AlexandreYang AlexandreYang changed the title [commands/check] Add discovery-instances-count option to agent check command [commands/check] Add discovery-instances option to agent check command Jan 6, 2022
@AlexandreYang AlexandreYang changed the title [commands/check] Add discovery-instances option to agent check command [commands/check] Add --discovery-instances option to agent check command Jan 6, 2022
@AlexandreYang AlexandreYang requested a review from a team January 6, 2022 16:38
cmd/agent/common/commands/check.go Outdated Show resolved Hide resolved
cmd/agent/common/commands/check.go Outdated Show resolved Hide resolved
cmd/agent/common/commands/check.go Outdated Show resolved Hide resolved
cmd/agent/common/commands/check.go Outdated Show resolved Hide resolved
AlexandreYang and others added 3 commits January 6, 2022 18:04
Co-authored-by: Ahmed Mezghani <38987709+ahmed-mez@users.noreply.github.com>
@AlexandreYang AlexandreYang merged commit 69cbebb into main Jan 7, 2022
@AlexandreYang AlexandreYang deleted the alex/discovery-retry-check-count branch January 7, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants