-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[commands/check] Add --discovery-instances
option to agent check
command
#10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreYang
changed the title
Add
Add Jan 6, 2022
discovery-retry-check-count
option to agent check
commanddiscovery-check-count
option to agent check
command
AlexandreYang
added
[deprecated] team/agent-core
Deprecated. Use metrics-logs / shared-components labels instead..
team/containers
labels
Jan 6, 2022
AlexandreYang
force-pushed
the
alex/discovery-retry-check-count
branch
from
January 6, 2022 16:02
ee3a209
to
005b470
Compare
AlexandreYang
changed the title
Add
[commands/check] Add Jan 6, 2022
discovery-check-count
option to agent check
commanddiscovery-check-count
option to agent check
command
4 tasks
AlexandreYang
changed the title
[commands/check] Add
[commands/check] Add Jan 6, 2022
discovery-check-count
option to agent check
commanddiscovery-instances-count
option to agent check
command
AlexandreYang
changed the title
[commands/check] Add
[commands/check] Add Jan 6, 2022
discovery-instances-count
option to agent check
commanddiscovery-instances
option to agent check
command
AlexandreYang
changed the title
[commands/check] Add
[commands/check] Add Jan 6, 2022
discovery-instances
option to agent check
command--discovery-instances
option to agent check
command
ahmed-mez
reviewed
Jan 6, 2022
Co-authored-by: Ahmed Mezghani <38987709+ahmed-mez@users.noreply.github.com>
djmitche
approved these changes
Jan 6, 2022
ahmed-mez
approved these changes
Jan 7, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
[deprecated] team/agent-core
Deprecated. Use metrics-logs / shared-components labels instead..
team/containers
team/network-device-monitoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
discovery-instances
option toagent check
commandCurrently, the
agent check
command waits for at least 1 check instance.If
discovery-instances
is used, theagent check
will wait for at least the specified number of check instances.Motivation
Needed for e2e testing listeners (snmp listener) that schedules multiple check instances.
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.team/..
label has been applied, if known.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.need-change/operator
andneed-change/helm
labels have been applied.