Skip to content

fix: set reason=ERROR for error-path evaluations #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typotter merged 1 commit into from
Sep 14, 2026
Merged

fix: set reason=ERROR for error-path evaluations #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions precomputed-assignments/cases/evaluator/defaults-and-emission-gates.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"defaultValue": false,
"expectedResult": {
"value": false,
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand All @@ -69,7 +69,7 @@
"defaultValue": false,
"expectedResult": {
"value": false,
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand All @@ -80,7 +80,7 @@
"defaultValue": "fallback",
"expectedResult": {
"value": "fallback",

@sameerank sameerank Sep 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dumb question and unrelated to approving this PR: is there ever a scenario when a fallback is not an error?

@typotter typotter Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. When there are not allocations in the UFC or zero of the allocations match the subject (this implies a lack of default allocation)

see ADR-01,04

"reason": null,
"reason": "ERROR",
"errorCode": "FLAG_NOT_FOUND",
"variantKey": null
}
Expand Down
6 changes: 3 additions & 3 deletions precomputed-assignments/cases/evaluator/empty-flags-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"defaultValue": false,
"expectedResult": {
"value": false,
"reason": null,
"reason": "ERROR",
"errorCode": "FLAG_NOT_FOUND",
"variantKey": null
}
Expand All @@ -30,7 +30,7 @@
"defaultValue": "fallback",
"expectedResult": {
"value": "fallback",
"reason": null,
"reason": "ERROR",
"errorCode": "FLAG_NOT_FOUND",
"variantKey": null
}
Expand All @@ -41,7 +41,7 @@
"defaultValue": 0,
"expectedResult": {
"value": 0,
"reason": null,
"reason": "ERROR",
"errorCode": "FLAG_NOT_FOUND",
"variantKey": null
}
Expand Down
12 changes: 6 additions & 6 deletions precomputed-assignments/cases/evaluator/type-mismatch-all-types.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "type-mismatch-all-types",
"description": "Each flag is evaluated as the wrong type. All must return their default value with a typeMismatch error. Note: the integer-as-float case (fixture.mismatch.int-as-float) is SDK-implementation-dependent — SDKs that allow implicit int-to-float promotion (Java, Swift, Dart) will not return typeMismatch for that evaluation. Add evaluation-level skipForSdks entries for those platforms once verified.",
"description": "Each flag is evaluated as the wrong type. All must return their default value with a typeMismatch error. Note: the integer-as-float case (fixture.mismatch.int-as-float) is SDK-implementation-dependent \u2014 SDKs that allow implicit int-to-float promotion (Java, Swift, Dart) will not return typeMismatch for that evaluation. Add evaluation-level skipForSdks entries for those platforms once verified.",
"context": {
"targetingKey": "mismatch-user",
"attributes": {}
Expand Down Expand Up @@ -62,7 +62,7 @@
"defaultValue": "fallback",
"expectedResult": {
"value": "fallback",
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand All @@ -73,7 +73,7 @@
"defaultValue": -1,
"expectedResult": {
"value": -1,
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand All @@ -84,7 +84,7 @@
"defaultValue": 0.0,
"expectedResult": {
"value": 0.0,
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
},
Expand All @@ -101,7 +101,7 @@
"defaultValue": false,
"expectedResult": {
"value": false,
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand All @@ -112,7 +112,7 @@
"defaultValue": "none",
"expectedResult": {
"value": "none",
"reason": null,
"reason": "ERROR",
"errorCode": "TYPE_MISMATCH",
"variantKey": null
}
Expand Down