Repository navigation
fix: set reason=ERROR for error-path evaluations - #39
Merged
Merged
Conversation
Both the browser SDK and Android SDK (DatadogFlagsClient) return reason=ERROR for all error evaluations (FLAG_NOT_FOUND, TYPE_MISMATCH) per the OpenFeature spec. The fixture schema used reason=null on error evaluations, which caused FLEX integration tests to fail when asserting the reason field. Affected fixtures: - evaluator/empty-flags-response.json - evaluator/defaults-and-emission-gates.json - evaluator/type-mismatch-all-types.json
typotter
requested review from
btthomas and
leoromanovsky
and removed request for
a team
September 14, 2026 18:51
sameerank
approved these changes
Sep 14, 2026
| @@ -80,7 +80,7 @@ | |||
| "defaultValue": "fallback", | |||
| "expectedResult": { | |||
| "value": "fallback", | |||
There was a problem hiding this comment.
A dumb question and unrelated to approving this PR: is there ever a scenario when a fallback is not an error?
Contributor
Author
There was a problem hiding this comment.
yes. When there are not allocations in the UFC or zero of the allocations match the subject (this implies a lack of default allocation)
see ADR-01,04
Contributor
Author
|
Thanks Sameeran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the browser SDK and Android SDK return
reason=ERRORfor all error evaluations (FLAG_NOT_FOUND, TYPE_MISMATCH) per the OpenFeature spec. The fixture schema usedreason=nullon error evaluations, causing FLEX integration tests to fail when asserting the reason field.Affected fixtures:
evaluator/empty-flags-response.jsonevaluator/defaults-and-emission-gates.jsonevaluator/type-mismatch-all-types.json