Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
When we added support for Faraday v1 in #906, a warning started to be emitted by Faraday versions < 1.0:
WARNING: Unexpected middleware set after the adapter. This won't be supported from Faraday 1.0.
This did not affect the correct behaviour of instrumentation on Faraday < 1.0.
This PR addresses that warning by patching Faraday < 1.0 using our old approach, the one removed in #906, instead of the new patching used by v1.0.
The removal of the old approach was originally intended, as the new patching used for 1.0 also works for < 1.0, as stated, but this warning we are seeing is not desirable either.
I've added a new Appraisal category for
contrib
to allow us to test older version:contrib-old
. I'm using it to test Faraday 0.17, while keeping our regular tests of the latest version of Faraday undercontrib
.