Skip to content

Warnings when using Faraday adapter with Farday 0.17.3 #965

Closed

Description

When configuring the Faraday adapter globally with

Datadog.configure do |c|
   c.use :faraday
end

I start seeing this deprecation warning all around:

WARNING: Unexpected middleware set after the adapter. This won't be supported from Faraday 1.0.

Seems to come from the way it's patching Faraday::Connection here:
https://github.com/DataDog/dd-trace-rb/blob/v0.32.0/lib/ddtrace/contrib/faraday/patcher.rb#L42
https://github.com/DataDog/dd-trace-rb/blob/v0.32.0/lib/ddtrace/contrib/faraday/connection.rb

From this issue (lostisland/faraday#946) seems like there's not currently a way to add a default middleware that'll be supported in v1.0.

Is this a know issue? Are there any workarounds around it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

bugInvolves a bugcommunityWas opened by a community memberintegrationsInvolves tracing integrations

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions