Update net/http instrumentation span annotation #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
requested changes
Jan 7, 2020
marcotc
added
community
delner
reviewed
Jan 9, 2020
delner
reviewed
Jan 10, 2020
delner
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue-888 . Currently, when a request raises an exception from a timeout(or otherwise), we don't annotate the span with any of the request or response details, since the
span_annotation!method is called after the request is made and an exception would get raised.This PR splits the
annotate_span!method into request and response specific annotation methods so that the span can be annotated with at least minimal tags in the case of an exception being raised by the request.Per the Contribution Guidelines I've also added a test for this use case.
Notes / Comments
Let me know what you think, happy to make any changes y'all feel would be appropriate here.