The net/http integration doesn't annotate requests that raise exceptions #888
Labels
bug
Involves a bug
community
Was opened by a community member
integrations
Involves tracing integrations
Milestone
If a net/http request raises an exception (e.g.
Net::OpenTimeout
), then the span is not annotated with tags from the request.See:
dd-trace-rb/lib/ddtrace/contrib/http/instrumentation.rb
Line 55 in ba583b5
annotate_span!
is called after the request completes and will be missed if an exception is raised. Since some of the annotations rely on having a response it should maybe be split into two parts, one called before the request is issued and one after.The text was updated successfully, but these errors were encountered: