[rails] Redis instrumentation follows users settings #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
force-pushed
the
palazzem/rails-redis
branch
from
df585ec
to
d3dcc88
Compare
palazzem
force-pushed
the
palazzem/rails-redis
branch
from
faae17b
to
b9496a8
Compare
palazzem
commented
Mar 7, 2017
| assert_equal(true, Rails.cache.respond_to?(:data), "cache '#{Rails.cache}' has no data") | ||
| pin = Datadog::Pin.get_from(Rails.cache.data) | ||
|
|
||
| # get the Redis pin accessing private methods (only Rails 3.x) |
There was a problem hiding this comment.
it's reasonable to do that in a test
palazzem
commented
Mar 7, 2017
| ::Rails.cache.is_a?(::ActiveSupport::Cache::RedisStore) | ||
| Datadog::Tracer.log.debug('Enabling auto-instrumentation for redis-rails connector') | ||
|
|
||
| # backward compatibility: Rails 3.x doesn't have `cache=` method |
There was a problem hiding this comment.
Rails 3.x relies in a RAILS_CACHE global; Rails > 3 deprecated this global in favor of a plain Rails.cache
…ld in early versions
palazzem
commented
Mar 7, 2017
| @@ -1,15 +0,0 @@ | |||
| module RedisStoreDataAccessor | |||
There was a problem hiding this comment.
had to remove this one because it was obfuscating how Rails 3.x works with cache. Think it should be fine now 👍
palazzem
commented
Mar 7, 2017
| # We include 'redis-rails' here if it's available, doing it later | ||
| # (typically in initialize callback) does not work, it does not | ||
| # get loaded in the right context. | ||
| require 'redis-rails' |
There was a problem hiding this comment.
we don't need to import that here, because it will be available after cache initialization (if present)
This was referenced Mar 7, 2017
ufoot
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
In the previous implementation Redis is automatically instrumented despite users settings. This caused many issues when the
Railsmodule is available but you're running external components (i.e.rakeorSidekiq).before_configurationhookafter_initializehook, so users' settings defined in the tracing initializer are honoreddebuglogRelated to