Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delay sampling decision to allow sampling on tags and resource #3956

Merged
merged 38 commits into from
Oct 7, 2024
Merged

feat: delay sampling decision to allow sampling on tags and resource #3956

merged 38 commits into from
Oct 7, 2024

Commits on Sep 24, 2024

  1. sample on all trace and root span tags

    @ZStriker19
    ZStriker19 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    0f3ff3e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. sample before digest

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    09b7afd View commit details
    Browse the repository at this point in the history

  2. only sample if sampling decision not already made

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    10af562 View commit details
    Browse the repository at this point in the history

  3. linting

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5f280bd View commit details
    Browse the repository at this point in the history

  4. sample trace before flush unless already sampled

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7203b51 View commit details
    Browse the repository at this point in the history

  5. change conditional

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7f4dceb View commit details
    Browse the repository at this point in the history

  6. remove sampling at span start

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f216d22 View commit details
    Browse the repository at this point in the history

  7. update trace operation to take tracer for sampling

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e9b2cd7 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'zachg/fix_sample_on_all_root_span_tags' into zachg/lazy… 

    …_sampling
    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    093d8c5 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'zachg/sample_before_digest' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d76927c View commit details
    Browse the repository at this point in the history

  10. Merge branch 'zachg/sample_before_trace_flush' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    63189ea View commit details
    Browse the repository at this point in the history

  11. check sampling priority differently

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    630e6f2 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'zachg/remove_sampling_at_span_start' into zachg/lazy_sa… 

    …mpling
    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a4d4615 View commit details
    Browse the repository at this point in the history

  13. fix get_metric

    @ZStriker19
    ZStriker19 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e6e38f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. change to checking sampling_priority before running sample

    @ZStriker19
    ZStriker19 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    83b24f3 View commit details
    Browse the repository at this point in the history

  2. integration tests for sampling with tag and resource combinations

    @ZStriker19
    ZStriker19 committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    60b9e09 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. broken trace_operation_spec test

    @ZStriker19
    ZStriker19 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fac3d5d View commit details
    Browse the repository at this point in the history

  2. fix how we call tracer in trace operation

    @ZStriker19
    ZStriker19 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    fab63c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'master' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    097cebc View commit details
    Browse the repository at this point in the history

  2. handle non-integer float edge case

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bba15ec View commit details
    Browse the repository at this point in the history

  3. Merge branch 'zachg/lazy_sampling' of github.com:DataDog/dd-trace-rb … 

    …into zachg/lazy_sampling
    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6d42bf8 View commit details
    Browse the repository at this point in the history

  4. handle non-integer float edge case

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5f4c58a View commit details
    Browse the repository at this point in the history

  5. fix tracer_spec tests since sampling happens at end

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9b3729d View commit details
    Browse the repository at this point in the history

  6. add edge case test for non zero decimal matching

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    424b9b5 View commit details
    Browse the repository at this point in the history

  7. test

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9390ccc View commit details
    Browse the repository at this point in the history

  8. it works

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    140355a View commit details
    Browse the repository at this point in the history

  9. * is the same as infinite *

    @ZStriker19
    ZStriker19 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7c483e4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8b202b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. * is the same as infinite * edge case test

    @ZStriker19
    ZStriker19 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    edf5c2f View commit details
    Browse the repository at this point in the history

  2. another test for matching float w/ zero decimal

    @ZStriker19
    ZStriker19 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    34457d4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    bf51dd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. tags test broken

    @ZStriker19
    ZStriker19 committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    bd41d98 View commit details
    Browse the repository at this point in the history

  2. fix tags test if meta is allowed in tags

    @ZStriker19
    ZStriker19 committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    469a92b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'master' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    ee8ddd8 View commit details
    Browse the repository at this point in the history

  2. trace operation tag takes precedence over root span tag

    @ZStriker19
    ZStriker19 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5648a4f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'zachg/lazy_sampling' of github.com:DataDog/dd-trace-rb … 

    …into zachg/lazy_sampling
    @ZStriker19
    ZStriker19 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    aca9e02 View commit details
    Browse the repository at this point in the history

  4. test metrics

    @ZStriker19
    ZStriker19 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f5f824b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into zachg/lazy_sampling

    @ZStriker19
    ZStriker19 authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bc81964 View commit details
    Browse the repository at this point in the history