feat: lazy sampling #3956
Draft
feat: lazy sampling #3956
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables lazy sampling with the feature being the ability to sample on tags and resource values for root spans. It does this by:
TraceOperationso that values from the root span will be returned if available, allowing sampling on all tags that will end up attached to the root span.TraceOperation.to_digestwhich runs before context propagationTracer.flushwhich runs before spans are written to the agent.Motivation:
The ability to sample on tags and resource will be helpful to users trying to reduce costs in a precise way as well as keep those spans that are truly useful to them.
Additional Notes:
How to test the change?
Unsure? Have a question? Request a review!