Allow passing web_service_name option to Rack through Rails tracer

[Surgo]

Allow passing web_service_name like #2082

[marcotc]

Thank you for this PR, @Surgo! 🙇
Would you mind adding a test to cover this new option?

[buraizu]

Thanks, approving with a minor update for accessibility

[esalter]

bump! Would love to see this land.

[tylerwillingham]

Just voicing support - my team would love to see this land too :)

[anmarchenko]

this line is probably not needed here as this option is still defined on line 55

[Surgo]

Removed at cb9ccbe

[marcotc]

@Surgo is there an issue with this being done at the Rack level, c.tracing.instrument :rack, web_service_name: ...?

[tylerwillingham]

@marcotc @Surgo speaking from another team at another company that was also surprised to learn that we couldn't pass web_service_name to the configuration for the rails instrument (like we do with request_queuing): we were similarly surprised when this option didn't pass through.

We spent a decent bit of time debugging and reading source code to realize "request_queuing" is getting special treatment (and it's pretty nice) but its sibling argument of "web_service_name" wasn't.

It feels like a precedent has been set to allow these args to pass through and it makes the configuration a little cleaner

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (22c0370) to head (8d51f83).
Report is 1439 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2716      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.01%     
==========================================
  Files        1253     1253              
  Lines       72690    72693       +3     
  Branches     3415     3415              
==========================================
- Hits        71405    71404       -1     
- Misses       1285     1289       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[langsharpe]

is there an issue with this being done at the Rack level, c.tracing.instrument :rack, web_service_name: ...?

I'm finding this isn't working for us (gem version 1.23.2). Any ideas? Otherwise, it would be nice for this PR to be merged.

Edit: The workaround did work in version 2.1.0.

Datadog.configure do |config|
    service_name = ENV.fetch("HEROKU_APP_NAME")

    config.tracing.instrument :rails, service_name: service_name, request_queuing: true
...
    config.tracing.instrument :rack, service_name: "#{service_name}-rack", web_service_name: "#{service_name}-puma"
end