Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing request_queuing option to Rack through Rails tracer #2082

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

KieranP
Copy link
Contributor

@KieranP KieranP commented Jun 12, 2022

Supporting this means I don't need to add and hacky overrides

@KieranP KieranP requested a review from a team June 12, 2022 22:21
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @KieranP! 🙇

@codecov-commenter
Copy link

Codecov Report

Merging #2082 (398cdae) into master (0646d7d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2082      +/-   ##
==========================================
- Coverage   97.49%   97.49%   -0.01%     
==========================================
  Files        1031     1031              
  Lines       53218    53218              
==========================================
- Hits        51884    51883       -1     
- Misses       1334     1335       +1     
Impacted Files Coverage Δ
...og/tracing/contrib/rails/configuration/settings.rb 97.14% <100.00%> (+0.08%) ⬆️
lib/datadog/tracing/contrib/rails/framework.rb 100.00% <100.00%> (ø)
spec/datadog/profiling/ext/forking_spec.rb 99.39% <0.00%> (-0.61%) ⬇️
lib/datadog/core/diagnostics/environment_logger.rb 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@marcotc marcotc added integrations Involves tracing integrations community Was opened by a community member labels Jun 20, 2022
@marcotc marcotc merged commit b1ed42d into DataDog:master Jun 20, 2022
@github-actions github-actions bot added this to the 1.2.0 milestone Jun 20, 2022
@ivoanjo
Copy link
Member

ivoanjo commented Jul 11, 2022

👋 @KieranP this change has been released in v1.2.0.
Thank you so much for the cool contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Was opened by a community member integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants